Enable customising node policy for datacarrier data size with a -datacarriersize option #5077
Conversation
|
Link/summary to miner requests? |
|
The (5-10 people? not big) Eligius tx policy discussion concluded on 80 byte OP_RETURNs, and I've personally observed various positive reactions from random third parties in response, though I didn't save links or anything. |
|
What are those third parties? If they are parties using the chain to store data when they could otherwise only store commitments, I'm not sure we want to support them more? |
| @@ -137,7 +137,7 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi | |||
| else if (opcode2 == OP_SMALLDATA) | |||
| { | |||
| // small pushdata, <= MAX_OP_RETURN_RELAY bytes | |||
| if (vch1.size() > MAX_OP_RETURN_RELAY) | |||
| if (vch1.size() > GetArg("-datacarriersize", MAX_OP_RETURN_RELAY)) | |||
There was a problem hiding this comment.
I'd seperate user input GetArg("-datacarriersize", ...) from actual logic.
There was a problem hiding this comment.
Yes I think I mentioned this before to @luke-jr in another pull for another issue. Re-parsing the argument every time this function runs is not a good idea, it should only be done once in AppInit2 or so.
There was a problem hiding this comment.
We're already re-parsing -datacarrier every time too. CNodePolicy would be moving these to AppInit2 anyway.
|
PR #5075 updates the logic to default to 80 bytes. |
|
@jgarzik Making it an option, sure...changing the default...probably should be discussed on the ML. |
…carriersize option
2b404e8 to
2aa6329
Compare
|
utACK |
|
2aa6329 Enable customising node policy for datacarrier data size with a -datacarriersize option (Luke Dashjr)
This seems to be something miners want control over.