Unique coinbase: Fixes #482 #505
Conversation
(extraNonce being reset due to just-occurred time change after nTime is set)
…dating time himself and stuff
…updating the time on their work until it's stale
…e coinbase txn is unique even if address is the same
…n/luke-jr-bitcoin into unique_coinbase
|
First of all, can we get commitmsgs that are readable? |
|
Ok I did the steps above in a fresh build of 0.4.0rc1 with the testnet-in-a-box files, and landed at code:-12 error: Keypool ran out, please call keypoolrefill first I then restarted my daemons with the -gen tag. Up to about 20 generated blocks now. My Ubuntu skills are lacking, the txids look unique to me; but obviously that's not good enough. Any help with http://bitcoin.stackexchange.com/questions/706/how-do-i-sort-the-output-of-listtransactions would be appreciated. Lastly, I'm not familiar with RPC - is there any resource for how I would do a getwork call wtih RPC? |
|
getwork is how external miners ask for block headers to work on, so to test it you'd fire up a miner and tell it to ask for work from your bitcoind. There's an external python-based miner in the config/pyminer/ directory (named pyminer.py) that aught to be handy for testing (it is very slow, though). If you're running testnet-in-a-box, note that you'll need to be running two bitcoinds talking to each other for any mining to get done. I just tried: pyminer.py bcc1.cfg ... and got: where bcc1.cfg contains settings that match my weird testnet-in-a-box setup (running with rpcport=9000): host=127.0.0.1 |
|
The commits are a bit messy - lots of changes that are not used in later commits. ACK on the actual code change though (though it needs testing). |
|
Tested, no duplicate txids. |
Unique coinbase: Fixes #482
Unique coinbase: Fixes #482
…chains 91dd327 Disable functional tests for bitcoin_functional build (Gregory Sanders) b8820d1 Activate CSV from genesis block for custom chains (Gregory Sanders) Pull request description: Guts the test for elements mode, can add back later if worked on. Tree-SHA512: a2b7633fa02dae582616ac26d25cd08f895d5940e3775c70cacdd3f678f01a21cbcaf56c6c540b91bd8535bb1aab7bdc59e2a79b5a1124cbd9d3f03f29d0b40e
Chapter 1,2,3 - punctuation, typos, simplifications
Fix from luke-jr, I reviewed the code but have not tested.
Rough sketch of a test plan:
-- verify: coinbase transactions have unique txids even though they pay-to default key
-- verify: coinbase transactions have unique txids