Simplify mining code (rerun of #5957) #5993
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| CBlockTemplate* CreateNewBlock(const CScript& scriptPubKeyIn) | ||
| CBlockTemplate* CreateNewBlock(const CScript& scriptPubKeyIn, CBlockIndex*& pindexPrev) |
There was a problem hiding this comment.
Given that you're changing the function, can you also pass const CChainParams& params ?
|
|
||
| LOCK(cs_main); | ||
| Checkpoints::fEnabled = false; | ||
|
|
||
| // Simple block creation, nothing special yet: | ||
| BOOST_CHECK(pblocktemplate = CreateNewBlock(scriptPubKey)); | ||
| BOOST_CHECK(pblocktemplate = CreateNewBlock(scriptPubKey, pindexPrev, Params())); |
There was a problem hiding this comment.
Thank you for doing this, but if you do it, you should do it right. That is, with
const CChainParams& params = Params(CBaseChainParams::MAIN);
at the beginning of the test case as in https://github.com/bitcoin/bitcoin/pull/5970/files#diff-5c64500485fda76388a86c95c0059585R53
|
Closing this until some other miner/wallet things are in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time without regtest mining slowdown.