refactor: move BDB (bitdb / db.h) interaction from init.cpp to wallet.cpp #5758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2015
|
ut ACK |
|
ut ACK |
|
Nice! Going to test. |
| if (r == CDBEnv::RECOVER_FAIL) | ||
| return InitError(_("wallet.dat corrupt, salvage failed")); | ||
| } | ||
| string warningString; |
There was a problem hiding this comment.
Nit: please use std::string. We'd like to get rid of the global using namespaces at some point.
There was a problem hiding this comment.
Okay. Updated. There are multiple string instantiations without the std:: namespace within init.cpp. I don't touch these (as well as the one i code-moved) for now.
this will remove db.h from init.cpp
4d64d99 to
2578975
Compare
laanwj
added a commit
that referenced
this pull request
Mar 20, 2015
…cpp to wallet.cpp 2bb1c87 refactor: move bdb (bitdb) interaction from init.cpp to wallet.cpp (Jonas Schnelli)
|
Merged via 2bb1c87 (trivial header conflict fixed) |
Warrows
added a commit
to Warrows/PIVX
that referenced
this pull request
Oct 14, 2019
Warrows
added a commit
to Warrows/PIVX
that referenced
this pull request
Nov 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will remove db.h from init.cpp