Push down RPC locks #5711
Merged
Push down RPC locks #5711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invalidateblock and reconsiderblock were defined doubly - remove no-longer-used threadSafe, as locks have been pushed down
51a328a to
5ebe095
Compare
|
Tested ACK. |
|
I assume there is a minimal post PR overhaul of https://github.com/bitcoin/bitcoin/blob/master/src/rpcmining.cpp#L444 required. IMO not urgent. |
|
This commit appears to have broken the rpc-test getblocktemplate_longpoll.py. Relevant failure: I'm not familiar enough with the test yet to understand what is going on, but I verified the test broke at this commit and succeeds in the previous one. |
|
I can confirm that the test is broken. I think it has to do with the |
jonasschnelli
added a commit
to jonasschnelli/bitcoin
that referenced
this pull request
Feb 4, 2015
getblocktemplate didn't have a wallet lock before bitcoin#5711 and IMO there is no need for LEAVE/ENTER critical section.
|
I don't see a need for https://github.com/bitcoin/bitcoin/blob/master/src/rpcmining.cpp#L451 LEAVE and ENTER crictial section. |
This was referenced Nov 14, 2015
random-zebra
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Jul 1, 2020
9f4868a [move] move listunspent to wallet/rpcwallet.cpp (furszy) e85e4f1 [RPC] Move RPC dispatch table registration to rpcwallet code (furszy) c0bc348 [RPC] push down reqWallet [first step] (furszy) cdb80a6 [RPC] Remove not used threadsafe in CRPCCommand (furszy) Pull request description: Initial work over the RPC dispatch table registration update. Includes the following changes: 1) Remove the unused threadSafe member from every CPRCCommand. (bitcoin#5711 , second commit) 2) Remove reqWallet from every CPRCCommand (bitcoin#5992 , second commit partially). 3) Move most of the wallet RPC commands registration to the rpcwallet file (bitcoin#7307 without the `EnsureWalletIsAvailable` on every RPC call --> mainly because the wallet RPC commands will only be registered if the wallet is available). to do: Move the remaining commands that were not moved from server to rpcwallet. ---------- Next step would be bitcoin#7766 (If anyone want to tackle it, feel more than welcome to tackle it). ACKs for top commit: Fuzzbawls: ACK 9f4868a random-zebra: All good. ACK 9f4868a and merging... Tree-SHA512: cd83cdc2de81efb5cb84d39753a160b19d8ca2967a1b303d85c3279559b478352c5a4316942c7a654e9c667b5a8f5bfa18020c1b6c9e78f4c408028840d0fc86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #5107.