-
Notifications
You must be signed in to change notification settings - Fork 37.7k
doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC" #33233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33233. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 2a815d1
PR updates dependencies document to point to version bump PR of capnproto.
- "code" review ✅
lgtm ACK 2a815d1 |
Code review ACK 2a815d1 Maybe we want to keep this PR open a little longer in case there are other small documentation updates like this? Seems fine to merge now though if preferred. May also want to include "doc:" in PR title Another little thing I noticed is that italics should be removed from these files in files.md since they are now included in binary releases: Lines 153 to 154 in 7d97894
|
Yes, I was assuming there would be more things showing up over the next few days. Though I can always open another PR. |
Also, on Fedora you need both packages, see maflcko/b-c-nightly@14d34ab. Suggested patch: diff --git a/doc/build-unix.md b/doc/build-unix.md
index 38b4496687..04f757ba52 100644
--- a/doc/build-unix.md
+++ b/doc/build-unix.md
@@ -122,7 +122,7 @@ User-Space, Statically Defined Tracing (USDT) dependencies:
Cap'n Proto is needed for IPC functionality (see [multiprocess.md](multiprocess.md)):
- sudo dnf install capnproto
+ sudo dnf install capnproto capnproto-devel
Compile with `-DENABLE_IPC=OFF` if you do not need IPC functionality.
|
You'll also need to add the |
Co-authored-by: maflcko <6399679+maflcko@users.noreply.github.com>
Arch instruction taken from: https://capnproto.org/install.html For Alpine I added |
8245640
to
de65c86
Compare
dev installs the other: https://cirrus-ci.com/task/6500081345495040?logs=install#L0 |
lgtm ACK de65c86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re ACK de65c86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though suggest renaming the PR title to
doc: follow-ups to "Add bitcoin-{node,gui} to release binaries for IPC"
@jonatack done, although I wasn't expecting there to be only doc changes. |
If there are more changes, there can be more PRs. We can fixup the docs now, and open more PRs when needed. |
dependencies.md
link to the PR that updated the capnp version: Add bitcoin-{node,gui} to release binaries for IPC #31802 (comment)