refactor: rename fees.{h,cpp} to fees/block_policy_estimator{h,cpp}
#33218
+39
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33218. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
policy/fees dir and rename fees.{h, cpp} to fees/block_policy_estimator{h, cpp}fees.{h, cpp} to fees/block_policy_estimator{h, cpp}
This was referenced Aug 20, 2025
- Also remame the test suite name to match the new name.
- Also move it to policy/fees and update the includes
- Also move them to policy/fees/ and update includes - Note: the block_policy_estimator_args.h include in block_policy_estimator_args.cpp was done manually.
6c917b8 to
c70781d
Compare
fees.{h, cpp} to fees/block_policy_estimator{h, cpp}fees.{h,cpp} to fees/block_policy_estimator{h,cpp}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a simple refactoring that does four things:
test/policy_fee_tests.cpptotest/feerounder_tests.cpp.policy/fees.{h,cpp}topolicy/fees/block_policy_estimator.{h,cpp}.policy/fees_args.cpptopolicy/fees/block_policy_estimator_args.cpp.estimateSmartFeeto return the block height at which the estimate was made by adding abest_heightunsigned int value to theFeeCalculationstruct.Motivation
In preparation for adding a new fee estimator, the
feesdirectory is created so we can organize code intoblock_policy_estimatorandmempoolbecausea) It would be clunky to add more code directly under
fees.b) Having
policy/fees.{h,cpp}andpolicy/mempool.{h,cpp}would also be undesirable.Therefore, it makes sense to structure the it as
policy/fees/block_policy_estimator,policy/fees/mempool, etc.Hence test file were also updated accordingly.
The current block height is also returned because later in #30157 we log the height at which each estimate is made (at the debug log category of fee estimation :) ). This feature is particularly useful for empirical data analysis.