build: Set AUTHOR_WARNING on warnings #33144
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33144. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Rebased, tested it with: diff --git a/CMakeLists.txt b/CMakeLists.txt
--- a/CMakeLists.txt (revision 27e4b8c6856194fa8db028b6f7356f83ea3d7e3a)
+++ b/CMakeLists.txt (date 1754504896922)
@@ -186,6 +186,7 @@
string(APPEND CMAKE_CXX_LINK_EXECUTABLE " ${APPEND_LDFLAGS}")
set(configure_warnings)
+list(APPEND configure_warnings "Testing https://github.com/bitcoin/bitcoin/pull/33144")
include(CheckLinkerSupportsPIE)
check_linker_supports_pie(configure_warnings)running: rm -rfd build && cmake -B build 2>&1 | grep -C1 WarningPrints before the change: CMake Warning at CMakeLists.txt:709 (message):
Testing https://github.com/bitcoin/bitcoin/pull/33144After the change: CMake Warning at CMakeLists.txt:709 (message):
Testing https://github.com/bitcoin/bitcoin/pull/33144
--
CMake Warning (dev) at CMakeLists.txt:712 (message):
Warnings have been encountered!
This warning is for project developers. Use -Wno-dev to suppress it.ACK fa6497b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the cmake setting
-Werror=devis set since commit 6a13a61 for the CI, guix and the dev cmake preset, it could make sense to notify developers about any warnings.So do that with a single
AUTHOR_WARNING.This can be tested by introducing a bug, like:
Fixes #31476.