-
Notifications
You must be signed in to change notification settings - Fork 37.7k
[29.x] Backports #33074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[29.x] Backports #33074
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33074. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
The BPF code was incorrectly passing pointer variables by value to bpf_usdt_readarg(), causing the function to fail silently and resulting in transaction hashes and reason strings displaying as zeros or garbage. This fix adds the missing reference operator (&) when passing pointer variables to bpf_usdt_readarg(), allowing the function to properly write the pointer values and enabling correct display of transaction hashes and removal/rejection reasons. Fixes the regression introduced in ec47ba3 where bpf_usdt_readarg_p was replaced with bpf_usdt_readarg but the calling convention wasn't properly updated for pointer arguments. Github-Pull: bitcoin#33086 Rebased-From: 0ce041e
59a1958
to
b98f19b
Compare
Currently there is a warning for this in guix-build, but we also need one in guix-codesign, otherwise the codesigned hashes are not reproducible. Move common functionality into prelude and call the function in both guix actions. Github-Pull: bitcoin#33073 Rebased-From: 1bed0f7
b98f19b
to
2d86ed1
Compare
This was missed in the v29.0 release notes.
2d86ed1
to
57f94ad
Compare
Github-Pull: bitcoin#33088 Rebased-From: 6757052
57f94ad
to
4dcf385
Compare
#33133 probably too |
The getpeerinfo docs incorrectly specified the ping durations as milliseconds. This was incorrectly changed in a3789c7 (released in v25; master since Sept. 2022). The correct duration unit is seconds. Also, remove the documentation of the getpeerinfo RPC response from the ping RPC since it's incomplete. Better to just reference the getpeerinfo RPC and it's documenation for this. Github-Pull: bitcoin#33133 Rebased-From: 1252eeb
4dcf385
to
02b258e
Compare
…nd_vin' is the correct field Github-Pull: bitcoin#33119 Rebased-From: 3543bfd
02b258e
to
b9e637b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK b9e637b
Compared the backport, didn't test
Backports:
cmake -B build -LH
up in Unix build docs #33088dumptxoutset
breaking change #33103