Skip to content

[29.x] Backports #33074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2025
Merged

[29.x] Backports #33074

merged 8 commits into from
Aug 15, 2025

Conversation

@fanquake fanquake added this to the 29.1 milestone Jul 28, 2025
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 28, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33074.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

The BPF code was incorrectly passing pointer variables by value to
bpf_usdt_readarg(), causing the function to fail silently and resulting
in transaction hashes and reason strings displaying as zeros or garbage.

This fix adds the missing reference operator (&) when passing pointer
variables to bpf_usdt_readarg(), allowing the function to properly
write the pointer values and enabling correct display of transaction
hashes and removal/rejection reasons.

Fixes the regression introduced in ec47ba3 where bpf_usdt_readarg_p
was replaced with bpf_usdt_readarg but the calling convention wasn't
properly updated for pointer arguments.

Github-Pull: bitcoin#33086
Rebased-From: 0ce041e
Currently there is a warning for this in guix-build, but we also need
one in guix-codesign, otherwise the codesigned hashes are not
reproducible.

Move common functionality into prelude and call the function in both
guix actions.

Github-Pull: bitcoin#33073
Rebased-From: 1bed0f7
This was missed in the v29.0 release notes.
@0xB10C
Copy link
Contributor

0xB10C commented Aug 4, 2025

#33133 probably too

The getpeerinfo docs incorrectly specified the ping durations as
milliseconds. This was incorrectly changed in a3789c7
(released in v25; master since Sept. 2022). The correct duration unit
is seconds.

Also, remove the documentation of the getpeerinfo RPC response from the
ping RPC since it's incomplete. Better to just reference the getpeerinfo
RPC and it's documenation for this.

Github-Pull: bitcoin#33133
Rebased-From: 1252eeb
Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b9e637b

Compared the backport, didn't test

@fanquake fanquake requested a review from willcl-ark August 13, 2025 09:58
@fanquake fanquake merged commit 837c5c7 into bitcoin:29.x Aug 15, 2025
18 checks passed
@fanquake fanquake deleted the 29_rc_backports branch August 15, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants