build: Explicitly set Qt's AUTO{MOC,RCC,UIC} property per target
#32951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids unnecessary dependencies for the `codegen` target when using Makefile generators.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32951. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
My Guix build: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codebase, which is compiled, consists of both files in the source tree and additional files generated during the build process. These generated files include headers such as
bitcoin-build-config.h, headers generated for tests and benchmarks from data files, and files produced by Qt's tools, such asmoc,rccanduic.When using Makefile or Ninja generators, CMake 3.31 and later provides a convenient builtin build target
codegen, which buildsallgenerated files. For example:or
However, when building with
-DBUILD_GUI=ON, setting theCMAKE_{AUTOMOC,RCC,UIC}variables globally introduces undesired dependencies for Makefiles generators, resulting in building dependencies directly unrelated to the generated files.This PR resolves that issue. The first commit refactors the build system by factoring out the main library from the
test_bitcoin-qtexecutable, just as is already done forbitcoinqtandbitcoin-qt, and prepares the ground for the second commit.