[29.x] Backports #32863
Merged
[29.x] Backports #32863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#32850 Rebased-From: d6aaffc
Some ambiguous uses of "we" referring to either the node or the peer are replaced with clearer phrasing. Also rephrase some comments for consistency and readability. Applies to all relevant outbound eviction tests in p2p_eviction_logic.py. Github-Pull: bitcoin#32823 Rebased-From: 26598ed
Ensure that tip_header.rehash() is used instead of tip_header.hash, which is None when the header is deserialized from hex. This avoids depending on wait_for_getheaders() falling back to any received message, making the test more explicit and robust. Github-Pull: bitcoin#32823 Rebased-From: ec004cd
When building depends on FreeBSD/OpenBSD `aarch64`, the host compilers
default to `default_host_{CC,CXX}`, which resolves to `gcc`/`g++`. This
is incorrect on these systems, where Clang is the default system
compiler.
Github-Pull: bitcoin#32716
Rebased-From: 4f10a57
Currently if the version 3 is selected for an otherwise standard spender, the test will fail. It's unlikely but possible, so change the test to update expectations and sample more aggressively on border values to instigate failures much quicker in the future if another version is made standard. Github-Pull: bitcoin#32841 Rebased-From: 4be81e9
…root Github-Pull: bitcoin#32859 Rebased-From: f0524cd
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32863. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_4_m |
This was referenced Jul 3, 2025
Github-Pull: bitcoin#32858 Rebased-From: 0a1af44
a49df4d to
c5db9de
Compare
Also, capitalized the comments in build-unix.md for uniformity with the docs on other targets. Github-Pull: bitcoin#32846 Rebased-From: 0e9f409
c5db9de to
56f37d5
Compare
- Update `check_smart_estimates` to calculate the fee rate ceiling by taking the maximum of fees seen, minrelaytxfee, and mempoolminfee. - Improve the subtest name and comments. Github-Pull: bitcoin#32463 Rebased-From: 5c1236f
- Increase block weight by 4000 for all nodes with custom -blockmaxweight. Prior to this commit, we generated blocks with 4000 weight units less worth of transactions. See bitcoin#32461 (comment) for details. This commit fixes it by increasing the block weight by 4000. Github-Pull: bitcoin#32463 Rebased-From: 9b75cfd
56f37d5 to
950f710
Compare
Github-Pull: bitcoin#32826 Rebased-From: 6967e8e
950f710 to
8ec282b
Compare
When using CMake policies 3.14 and below, the `export(PACKAGE)` command by default populates the user package registry, which is stored outside the build tree. Setting the `CMAKE_EXPORT_NO_PACKAGE_REGISTRY` variable disables this side effect. In CMake 3.15 and later, this behavior is disabled by default, and the variable has no effect. Github-Pull: bitcoin#32943 Rebased-From: 44f3bae
8ec282b to
311434d
Compare
Github-Pull: bitcoin#32954 Rebased-From: 12a6959
Starting with version 13.x, the mingw headers will define the value of NTDDI_VERSION, based on the value of _WIN32_WINNT, if that version is < Windows 10. Given that libevent was undefining our _WIN32_WINNT, and redefining it to a value < Windows 10 (0x0501), NTDDI_VERSION was also being defined to that value, leading to functions not being exposed in the mingw-w64 headers; see here: https://github.com/mingw-w64/mingw-w64/blob/9c2668ef77e75ea4d8a6c7d100b14643269caec3/mingw-w64-headers/include/iphlpapi.h#L36-L41. Imports a commit from usptream (a14ff91254f40cf36e0fee199e26fb11260fab49). Fixes bitcoin#32707. Github-Pull: bitcoin#32837 Rebased-From: f5647c6
311434d to
5300295
Compare
hebasto
approved these changes
Jul 17, 2025
There was a problem hiding this comment.
ACK 5300295, I've backported all listed PRs locally (had 3 conflicts to resolve), and got zero diff with this PR.
The last commit also addresses #32810 (review).
glozow
reviewed
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports
feature_fee_estimation.pysubtest #32463_WIN32_WINNTusage #32837CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE#32943