Skip to content

Conversation

@fanquake fanquake added this to the 28.3 milestone Jun 25, 2025
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 25, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32811.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

willcl-ark and others added 2 commits June 27, 2025 15:06
Current behaviour will by-default use SOURCE_DATE_EPOCH from the
environment without warning. This breaks the default reproducibility
from a guix build.

Warn when and exit when this variable is set, and
FORCE_SOURCE_DATE_EPOCH is unset.

Github-Pull: bitcoin#32678
Rebased-From: 5c4a0f8
@fanquake fanquake force-pushed the 28_more_backporting branch from 6a203f7 to 44b07b2 Compare June 27, 2025 14:07
@fanquake fanquake marked this pull request as ready for review July 2, 2025 12:24
@fanquake fanquake requested review from willcl-ark and hebasto July 2, 2025 12:24
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 44b07b2.

@fanquake fanquake merged commit 3c56d36 into bitcoin:28.x Jul 3, 2025
15 of 16 checks passed
@fanquake fanquake deleted the 28_more_backporting branch July 3, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants