guix: Build for macOS using Clang only #32764
Open
+85
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32764. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
My Guix build: |
fanquake
reviewed
Jun 19, 2025
| @@ -493,6 +493,54 @@ inspecting signatures in Mach-O binaries.") | |||
| (("^install-others =.*$") | |||
| (string-append "install-others = " out "/etc/rpc\n"))))))))))))) | |||
|
|
|||
| (define-public libcxx-18 ;; 18.1.8 | |||
There was a problem hiding this comment.
In 6ad54dc: Rather than adding a package here, I think we should wait until we next bump the time-machine (I've got a branch with some changes for this), where we'll likely use LLVM/Clang 19, and then can just use libcxx (19). We could also upstream a libcxx-20 now, which could then be used if we switch to LLVM/Clang 20.
There was a problem hiding this comment.
In 6ad54dc: Rather than adding a package here, I think we should wait until we next bump the time-machine (I've got a branch with some changes for this), where we'll likely use LLVM/Clang 19, and then can just use
libcxx(19).
That was my initial approach, as suggested in #30206 (comment). Unfortunately, there's an upstream issue in Guix affecting the riscv64 host:
riscv64-linux-gnu-ld: relocation R_RISCV_RVC_JUMP against `__sigsetjmp' which may bind externally can not be used when making a shared object; recompile with -fPIC
...
build of /gnu/store/2drzypp2rgya0qcab3izkv9d8ib0kqvv-glibc-cross-riscv64-linux-gnu-2.31.drv failed
There was a problem hiding this comment.
Unfortunately, there's an upstream issue in Guix affecting the riscv64 host:
See #33185.
|
My Guix build matches @hebasto. No opinion on the change though. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes macOS builds Clang-only by switching the build compiler in depends to
clang+libc++.See: #30206.