[28.x] 28.2rc2 #32684
Merged
[28.x] 28.2rc2 #32684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the mkdir detection in xproto is broken on Alpine. Ensure we always use `mkdir -p`. Fixes bitcoin#32494. Github-Pull: bitcoin#32568 Rebased-From: df9ebbf
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32684. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. LLM Linter (✨ experimental)Possible typos and grammar issues:
drahtbot_id_4_m |
|
Guix Build: be30f094366c71bd7251247319dbb0cf1b5674d13e210685328daff1bf855766 guix-build-3b05c498a08e/output/aarch64-linux-gnu/SHA256SUMS.part
1823e9b3d7c97a533ab77540095223bc48759216b9e9fe757f24575f2323680f guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu-debug.tar.gz
8fd4d3a844e845ae13a95d165ae2cd1fea735295c24bc68b3fd28cb91f59c397 guix-build-3b05c498a08e/output/aarch64-linux-gnu/bitcoin-3b05c498a08e-aarch64-linux-gnu.tar.gz
b86f8537ceb5f364d6be26a488dc21580697ecfb9d7cc7e1a9d691a611c57324 guix-build-3b05c498a08e/output/arm-linux-gnueabihf/SHA256SUMS.part
516a8e1220b18f656f5d1d946ab96f825556d83f32d1ce41fc3f483a246d918b guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf-debug.tar.gz
6d211598a16829142b608f2b85d138c0346ae7057a21e834f7293f9d04d80dea guix-build-3b05c498a08e/output/arm-linux-gnueabihf/bitcoin-3b05c498a08e-arm-linux-gnueabihf.tar.gz
d133dc0b3081a7048bcf6c7cd0d61333b2372f2763154887069b32ff8ac8ec13 guix-build-3b05c498a08e/output/arm64-apple-darwin/SHA256SUMS.part
863ac4e5fcb95766b81039cd85b2740791a3f65e4b6fd0d39fe57cb182e299aa guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-codesigning.tar.gz
765aed969c45f09fc1df4ba3c802d137ad5776101833d63a0d4957ab0802c0b0 guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.tar.gz
47a51e1078002b929c3750cf7c292f576448a42c9fa096efdcb5722682c95f18 guix-build-3b05c498a08e/output/arm64-apple-darwin/bitcoin-3b05c498a08e-arm64-apple-darwin-unsigned.zip
3dd79826cbce2e43f1767c15b6b8ed529f0278f6ef721a11fd5e1bdd6aebe8b6 guix-build-3b05c498a08e/output/dist-archive/bitcoin-3b05c498a08e.tar.gz
c4764be65da14dddd84eff11b014cb7d9e01ab8445bf2fe025615455a867aea6 guix-build-3b05c498a08e/output/powerpc64-linux-gnu/SHA256SUMS.part
4b10398475e242acb88b07f550d18e1c7201d6af277489cdd9d626bc966c505d guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu-debug.tar.gz
67fa43a82454fe19048cff94f9b3a9fd875cace5081db517b623ee62d1625a61 guix-build-3b05c498a08e/output/powerpc64-linux-gnu/bitcoin-3b05c498a08e-powerpc64-linux-gnu.tar.gz
df16a3f91cff89c05285d447687036847e5ddacde10fa1978f5e8fd0a05a0dc0 guix-build-3b05c498a08e/output/riscv64-linux-gnu/SHA256SUMS.part
46a3159a395b460b969a34424534ecfe8d2124012c35b4eec41c5039f7729657 guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu-debug.tar.gz
30cad7f8bb940bc2553ab6b332eaa8fab5b0f58f0c08f03fa236cda7cc0f898e guix-build-3b05c498a08e/output/riscv64-linux-gnu/bitcoin-3b05c498a08e-riscv64-linux-gnu.tar.gz
6e3329a9e7eb492d4e0af3a86b204da17cb2716c30aa56e6ee701e88d712fc78 guix-build-3b05c498a08e/output/x86_64-apple-darwin/SHA256SUMS.part
e0a93c6aae317f108aee97aa5625eeb94513e03913a1adb80f64a1525c442398 guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-codesigning.tar.gz
8809523d83765ef203f20502c20abe2a0503ffee96f5d259ac938648f2e9006d guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.tar.gz
8a0408595e3f46fe07cfd8eaa7e90a58d508d8d4204eef3e8903e00c8fc757ca guix-build-3b05c498a08e/output/x86_64-apple-darwin/bitcoin-3b05c498a08e-x86_64-apple-darwin-unsigned.zip
0633262002f982db8925af044457d3440b49b4462af29f1cc5766ce17f7160a6 guix-build-3b05c498a08e/output/x86_64-linux-gnu/SHA256SUMS.part
3369dbbe926b844a44e9629aed18f91ab9894b353be96bf861a5ffb56265f876 guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu-debug.tar.gz
6beb32dd287210021a883112663d0298761ae9c2fb5ecec960debc3805893a4e guix-build-3b05c498a08e/output/x86_64-linux-gnu/bitcoin-3b05c498a08e-x86_64-linux-gnu.tar.gz
1f5edb8d261c48722648f2df3c95ca687d08e6d3f15f2e5afa94f6e51406c104 guix-build-3b05c498a08e/output/x86_64-w64-mingw32/SHA256SUMS.part
b89a8df1360bed7aed3d41242b5ba205441df3e6c44c4d36902571372f290c8b guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-codesigning.tar.gz
646855d3bff2b7b824d58dbdc5ec2981374641c9cdaacc7dce5a78babf99573b guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-debug.zip
bf13ad6e60d699aa33cab7c9dad72a32edc60cb2c512393dd9dcfbe8d3a64fc8 guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-setup-unsigned.exe
74f0251c369e49162ddbf745df389ee50f70734bcdfb8a6ca5c38ae93acd4f48 guix-build-3b05c498a08e/output/x86_64-w64-mingw32/bitcoin-3b05c498a08e-win64-unsigned.zip |
willcl-ark
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
crACK 3b05c49
will kick off a guix build over lunch, but backport and version changes all appear correct
|
glozow
reviewed
Jun 6, 2025
willcl-ark
approved these changes
Jun 7, 2025
|
ACK fb62393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #32568.
Bumps to
rc2.#32563 & #32639 haved landed since
rc1.