-
Notifications
You must be signed in to change notification settings - Fork 37.7k
depends: sqlite 3.50.4; switch to autosetup #32655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32655. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
@@ -17,6 +17,7 @@ | |||
((gnu packages python) #:select (python-minimal)) | |||
((gnu packages python-build) #:select (python-tomli python-poetry-core)) | |||
((gnu packages python-crypto) #:select (python-asn1crypto)) | |||
(gnu packages tcl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this affect the overall dependency graph?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tcl
was already included in the build environment as a runtime dependency for python
via ninja -> python-wrapper -> python
.
With this change, no new runtime dependencies are included in the build environment. The only difference is that tclsh
(and other helper binaries included in the tcl
package) are now available on PATH
.
aad0545
to
3846cd9
Compare
Migrate to the new Autosetup build system (introduced in 3.48.0). See https://msteveb.github.io/autosetup/. Also: https://sqlite.org/releaselog/3_50_0.html.
3fa73d5
to
1c3e068
Compare
We currently use SQLite
3.46.1
in depends. Migrating to any version after3.49.0
(with our use of the amalgamation tarball), requires migrating to to building SQLite withautosetup
, which is a replacement for Autoconf. This is what that will look like.