Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Jun 1, 2025

We currently use SQLite 3.46.1 in depends. Migrating to any version after 3.49.0 (with our use of the amalgamation tarball), requires migrating to to building SQLite with autosetup, which is a replacement for Autoconf. This is what that will look like.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 1, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32655.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #33185 (guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2 by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@@ -17,6 +17,7 @@
((gnu packages python) #:select (python-minimal))
((gnu packages python-build) #:select (python-tomli python-poetry-core))
((gnu packages python-crypto) #:select (python-asn1crypto))
(gnu packages tcl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this affect the overall dependency graph?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tcl was already included in the build environment as a runtime dependency for python via ninja -> python-wrapper -> python.

With this change, no new runtime dependencies are included in the build environment. The only difference is that tclsh (and other helper binaries included in the tcl package) are now available on PATH.

@fanquake fanquake changed the title depends: sqlite 3.50.0; switch to autosetup depends: sqlite 3.50.1; switch to autosetup Jun 7, 2025
@fanquake fanquake force-pushed the sqlite_3_50_0 branch 2 times, most recently from aad0545 to 3846cd9 Compare June 30, 2025 10:54
@fanquake fanquake changed the title depends: sqlite 3.50.1; switch to autosetup depends: sqlite 3.50.2; switch to autosetup Jul 2, 2025
@fanquake fanquake changed the title depends: sqlite 3.50.2; switch to autosetup depends: sqlite 3.50.3; switch to autosetup Jul 24, 2025
@fanquake fanquake changed the title depends: sqlite 3.50.3; switch to autosetup depends: sqlite 3.50.4; switch to autosetup Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants