fuzz: wallet: add target for MigrateToDescriptor
#32624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32624. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
13 tasks
maflcko
reviewed
May 27, 2025
08b574d to
5f2fb4d
Compare
|
08b574d..5f2fb4d: Address #32624 (comment) |
5f2fb4d to
73439a7
Compare
maflcko
reviewed
Jun 17, 2025
73439a7 to
6d29c9a
Compare
|
lgtm ACK 6d29c9a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fuzz coverage for the scriptpubkeyman migration (
MigrateToDescriptor). Note that it's a test for the migration of the scriptpubkey manager, not for the whole migration process as tried in #29694, because:This target loads keys, HDChain (even inactive ones), watch only and might add tons of different scripts, then calls
MigrateToDescriptor. It does not play with encrypted stuff because it would make the target super slow. Also, after the migration there are some assertions that would work as a regression test for #31452, for example.