bench: replace embedded raw block with configurable block generator #32554
+272
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `bench/block_generator.{h,cpp}` that builds a fully valid block at runtime and exposes:
- `GetBlock()` - in-memory `CBlock`;
- `GetBlockData()` - serialized `DataStream`;
so benchmarks can fetch whichever form they need.
* Generation is steered by `ScriptRecipe`:
- per-type probabilities for legacy, P2SH, v0/v1 witness, anchor, multisig, OP_RETURN, non-standard, …
- a geometric base that controls input/output counts, witness-stack depth, amounts, versions, lock-times, sequences, …
Presets `kLegacy` (pre-SegWit) and `kWitness` (Taproot-era) are included, callers can supply custom mixes.
* Deterministic `FastRandomContext` yields identical output on every run while avoiding repetition and predictability bias.
* Blocks are mined against the easiest allowed target, then run through `CheckBlock()` to ensure full validity.
This delivers diverse, up-to-date test data without adding another megabyte-scale binary to the repository and lets us retune workloads as network patterns evolve.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32554. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Concept ACK |
This was referenced May 19, 2025
|
Concept ACK This one is pretty useful as I can test with up-to date test_data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #32457 which replaces the current benchmark block 413567 from 2016 with block 784588 from 2023.
Added
bench/block_generator.{h,cpp}that builds a fully valid block at runtime and exposes a serialized and an in-memory block, so benchmarks can fetch whichever form they need:-
GetBlock()- in-memoryCBlock;-
GetBlockData()- serializedDataStream.ScriptRecipe:Presets
kLegacy(pre-SegWit) andkWitness(Taproot-era) are included, callers can supply custom mixes.FastRandomContextyields identical output on every run while avoiding repetition and predictability bias.CheckBlock()to ensure full validity.This delivers diverse, up-to-date test data without adding another megabyte-scale binary to the repository and lets us retune workloads as network patterns evolve.