coins: fix `cachedCoinsUsage` accounting in `CCoinsViewCache` #32313

l0rinc · 2025-04-20T17:33:09Z

Split out of #32296 (comment) since this needed more complicated production code changes.

The changes ensure cachedCoinsUsage remains balanced throughout all coin operations and that the sanitizers will catch future violations.

You can recreate the previous failures as described in #32313 (comment):

MAKEJOBS="-j$(nproc)" FILE_ENV="./ci/test/00_setup_env_native_fuzz.sh" ./ci/test_run_all.sh

The change was tested with the related fuzz test, and asserted before/after each cachedCoinsUsage change (in production code and fuzz) that the calculations are still correct by recalculating it from scratch.

Details

bool CCoinsViewCache::CacheUsageValid() const
{
    size_t actual{0};
    for (auto& entry : cacheCoins | std::views::values) actual += entry.coin.DynamicMemoryUsage();
    return actual == cachedCoinsUsage;
}

This part wasn't committed to the code.

DrahtBot · 2025-04-20T17:33:13Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32313.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#33018 (coins: remove SetFresh method from CCoinsCacheEntry by andrewtoth)
#31132 (validation: fetch block inputs on parallel threads 10% faster IBD by andrewtoth)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

src/coins.cpp

andrewtoth · 2025-04-20T17:43:18Z

src/coins.cpp

@@ -195,6 +201,7 @@ bool CCoinsViewCache::BatchWrite(CoinsViewCacheCursor& cursor, const uint256 &ha
                // and mark it as dirty.
                itUs = cacheCoins.try_emplace(it->first).first;
                CCoinsCacheEntry& entry{itUs->second};
+                cachedCoinsUsage -= entry.coin.DynamicMemoryUsage();


The entry has an empty coin here, it was just created. So this is just subtracting zero.

Thanks, I'll add an assert in that case to explain why this branch wasn't symmetric with the other one.

I don't think we should add an assert here to explain. The comment right above says Create the coin in the parent cache.

Doesn't the presence of the original cache-usage-update indicate that the comment isn't enough?

Sorry, what is the original cache-usage-update? AFAICT this line was added in this PR, and there is no cache-usage-update here?

I prefer code over comments (the comment can be wrong, the code validates) - and since the usual pattern is basically:

cachedCoinsUsage -= itUs->second.coin.DynamicMemoryUsage(); if (cursor.WillErase(*it)) { itUs->second.coin = std::move(it->second.coin); } else { itUs->second.coin = it->second.coin; } cachedCoinsUsage += itUs->second.coin.DynamicMemoryUsage();

it makes sense to explain (via code) why here we don't need the first part:

assert(entry.coin.DynamicMemoryUsage() == 0); // i.e. we didn't forget the symmetry, it's on purpose if (cursor.WillErase(*it)) { entry.coin = std::move(it->second.coin); } else { entry.coin = it->second.coin; } cachedCoinsUsage += entry.coin.DynamicMemoryUsage();

Do you still think we don't need it?

l0rinc · 2025-04-29T09:50:46Z

Rebased to allow CI running the new tests.

maflcko · 2025-04-29T20:46:02Z

test/sanitizer_suppressions/ubsan

@@ -46,9 +46,6 @@ unsigned-integer-overflow:CRollingBloomFilter::insert
 unsigned-integer-overflow:RollingBloomHash
 unsigned-integer-overflow:CCoinsViewCache::AddCoin
 unsigned-integer-overflow:CCoinsViewCache::BatchWrite
-unsigned-integer-overflow:CCoinsViewCache::DynamicMemoryUsage
-unsigned-integer-overflow:CCoinsViewCache::SpendCoin
-unsigned-integer-overflow:CCoinsViewCache::Uncache


it would be better to file this separately and explain why it isn't needed (or rather since when)

They were introduced in https://github.com/bitcoin/bitcoin/pull/28865/files#diff-bca63b54ad7fcc2df12f3237fd8775810c1b849c49110f702920655778fcc248R45-R49, I don't see any concrete explanation for what the problem was - and couldn't reproduce any fuzzing problem when I've removed these.
@fanquake, can you help us out here, do you remember why these were added?

I ran the following on Linux for a1fe87eb668e8a1eeeef335951547882b5fb52d8:

cmake --preset=libfuzzer && cmake --build build_fuzz && \ FUZZ=coin_grinder build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coin_grinder_is_optimal build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coincontrol build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coins_deserialize build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coins_view build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coinscache_sim build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coinselection_bnb build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coinselection_knapsack build_fuzz/bin/fuzz -runs=500000 && \ FUZZ=coinselection_srd build_fuzz/bin/fuzz -runs=500000

They all passed (actually ran a few until -runs=1000000 but got bored at the end).
Am I missing anything important here?

Am I missing anything important here?

Yes, the preset doesn't check for those. You'll have to run with the integer sanitizer to be able to detect integer sanitizer issues.

The testing steps are also explained in the comment: #28865 (comment)

As mentioned in #32296 (comment), I can't always reproduce these locally, it's why I used the CI to verify why these were needed in the first place.
I have tried every combination I could think of locally, I couldn't reproduce any such errors in coins. If you can, please let me know how to do that exactly.
Is there any other CI run I should be looking at to see if there are other failures?

Whenever I tried going back to pre-cmake times, I couldn't get it to compile and run again (on Mac or on Linux). Not the first time I try to do a git bisect, but it always turns bad really quickly.

I tried pushing a PR to my fork with the original PR that introduced the suppressions + removing DynamicMemoryUsage, SpendCoin and Uncache suppressionss from ubsan.
The build is failing with similar problems that I see locally but don't see any unsigned-integer-overflow complaints. #28865 l0rinc#10

Can you give me a hint of what else to try?

They were introduced in https://github.com/bitcoin/bitcoin/pull/28865/files#diff-bca63b54ad7fcc2df12f3237fd8775810c1b849c49110f702920655778fcc248R45-R49,
@fanquake, can you help us out here, do you remember why these were added?

You can recreate the failures by checking out to that commit (fd30e96), applying this diff (which includes the supression being done here):

diff --git a/ci/test/00_setup_env_native_fuzz.sh b/ci/test/00_setup_env_native_fuzz.sh index 3585b2b417..ce45917e99 100755 --- a/ci/test/00_setup_env_native_fuzz.sh +++ b/ci/test/00_setup_env_native_fuzz.sh @@ -6,7 +6,7 @@ export LC_ALL=C.UTF-8 -export CI_IMAGE_NAME_TAG="docker.io/ubuntu:23.10" # This version will reach EOL in Jul 2024, and can be replaced by "ubuntu:24.04" (or anything else that ships the wanted clang version). +export CI_IMAGE_NAME_TAG="docker.io/ubuntu:24.04" # This version will reach EOL in Jul 2024, and can be replaced by "ubuntu:24.04" (or anything else that ships the wanted clang version). export CONTAINER_NAME=ci_native_fuzz export PACKAGES="clang-17 llvm-17 libclang-rt-17-dev libevent-dev libboost-dev libsqlite3-dev" export NO_DEPENDS=1 diff --git a/test/sanitizer_suppressions/ubsan b/test/sanitizer_suppressions/ubsan index 63d2215aab..d3fc2a59ff 100644 --- a/test/sanitizer_suppressions/ubsan +++ b/test/sanitizer_suppressions/ubsan @@ -42,11 +42,6 @@ unsigned-integer-overflow:arith_uint256.h unsigned-integer-overflow:CBloomFilter::Hash unsigned-integer-overflow:CRollingBloomFilter::insert unsigned-integer-overflow:RollingBloomHash -unsigned-integer-overflow:CCoinsViewCache::AddCoin -unsigned-integer-overflow:CCoinsViewCache::BatchWrite -unsigned-integer-overflow:CCoinsViewCache::DynamicMemoryUsage -unsigned-integer-overflow:CCoinsViewCache::SpendCoin -unsigned-integer-overflow:CCoinsViewCache::Uncache unsigned-integer-overflow:CompressAmount unsigned-integer-overflow:DecompressAmount unsigned-integer-overflow:crypto/

and running the native_fuzz CI job (on aarch64):

time env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j17" FILE_ENV="./ci/test/00_setup_env_native_fuzz.sh" ./ci/test_run_all.sh' <snip> #170921 REDUCE cov: 1694 ft: 6197 corp: 478/22Kb lim: 240 exec/s: 3351 rss: 208Mb L: 20/219 MS: 1 EraseBytes- #171261 REDUCE cov: 1694 ft: 6200 corp: 479/22Kb lim: 240 exec/s: 3358 rss: 208Mb L: 193/219 MS: 5 ChangeBinInt-ChangeBit-ChangeByte-CrossOver-CrossOver- #171550 REDUCE cov: 1694 ft: 6200 corp: 479/22Kb lim: 240 exec/s: 3363 rss: 208Mb L: 42/219 MS: 4 CopyPart-ChangeByte-PersAutoDict-EraseBytes- DE: "\024\000"- #171657 REDUCE cov: 1694 ft: 6200 corp: 479/22Kb lim: 240 exec/s: 3365 rss: 208Mb L: 51/219 MS: 2 InsertByte-EraseBytes- coins.cpp:132:22: runtime error: unsigned integer overflow: 0 - 64 cannot be represented in type 'size_t' (aka 'unsigned long') #0 0xaaaab73bc134 in CCoinsViewCache::SpendCoin(COutPoint const&, Coin*) src/coins.cpp:132:22 #1 0xaaaab57cbc94 in coins_view_fuzz_target(Span<unsigned char const>)::$_4::operator()() const src/test/fuzz/coins_view.cpp:89:40 #2 0xaaaab57cbc94 in unsigned long CallOneOf<coins_view_fuzz_target(Span<unsigned char const>)::$_0, coins_view_fuzz_target(Span<unsigned char const>)::$_1, coins_view_fuzz_target(Span<unsigned char const>)::$_2, coins_view_fuzz_target(Span<unsigned char const>)::$_3, coins_view_fuzz_target(Span<unsigned char const>)::$_4, coins_view_fuzz_target(Span<unsigned char const>)::$_5, coins_view_fuzz_target(Span<unsigned char const>)::$_6, coins_view_fuzz_target(Span<unsigned char const>)::$_7, coins_view_fuzz_target(Span<unsigned char const>)::$_8, coins_view_fuzz_target(Span<unsigned char const>)::$_9, coins_view_fuzz_target(Span<unsigned char const>)::$_10>(FuzzedDataProvider&, coins_view_fuzz_target(Span<unsigned char const>)::$_0, coins_view_fuzz_target(Span<unsigned char const>)::$_1, coins_view_fuzz_target(Span<unsigned char const>)::$_2, coins_view_fuzz_target(Span<unsigned char const>)::$_3, coins_view_fuzz_target(Span<unsigned char const>)::$_4, coins_view_fuzz_target(Span<unsigned char const>)::$_5, coins_view_fuzz_target(Span<unsigned char const>)::$_6, coins_view_fuzz_target(Span<unsigned char const>)::$_7, coins_view_fuzz_target(Span<unsigned char const>)::$_8, coins_view_fuzz_target(Span<unsigned char const>)::$_9, coins_view_fuzz_target(Span<unsigned char const>)::$_10) src/./test/fuzz/util.h:43:27 #3 0xaaaab57cbc94 in coins_view_fuzz_target(Span<unsigned char const>) src/test/fuzz/coins_view.cpp:58:9 #4 0xaaaab5d2319c in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/aarch64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591:9 #5 0xaaaab5d2319c in LLVMFuzzerTestOneInput src/test/fuzz/fuzz.cpp:178:5 #6 0xaaaab5545050 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1925050) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #7 0xaaaab5544798 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1924798) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #8 0xaaaab5545f90 in fuzzer::Fuzzer::MutateAndTestOne() (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1925f90) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #9 0xaaaab5546cdc in fuzzer::Fuzzer::Loop(std::vector<fuzzer::SizedFile, std::allocator<fuzzer::SizedFile>>&) (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1926cdc) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #10 0xaaaab5534e70 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x1914e70) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #11 0xaaaab555e0ac in main (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x193e0ac) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) #12 0xffffb4aa84c0 (/lib/aarch64-linux-gnu/libc.so.6+0x284c0) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04) #13 0xffffb4aa8594 in __libc_start_main (/lib/aarch64-linux-gnu/libc.so.6+0x28594) (BuildId: 1d7249a4f207d07166ff4be43acdc68a01faaa04) #14 0xaaaab552afac in _start (/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz+0x190afac) (BuildId: 82e180570288de2f70ceeee1ed5d7cd3729696ab) SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow coins.cpp:132:22 in MS: 1 CopyPart-; base unit: 81111e927920a57969bb7efb23d89de00d09a5ec 0xff,0xef,0xfe,0x0,0x1,0x3,0x0,0x1,0xff,0xff,0xff,0xff,0xff,0x3,0x0,0x1,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x3,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xfe,0xff,0xfa,0x0,0x0,0x0,0x0,0x80,0x76,0x0,0x0,0x0,0x0,0x68,0x5c,0xff,0xff,0xff,0xff,0xef,0xfe,0x0,0x1,0x3,0x0,0x1,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x3,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x3,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xfe,0xff,0xfa,0x0,0x0,0x0,0x0,0x80,0x76,0x0,0x0,0x0,0x0,0x68,0x5c,0xff,0xff,0xff,0xff,0xef,0xfe,0x0,0x1,0x3,0x0,0x1,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0x3,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xff,0xfe,0xff,0xfa,0x7, \377\357\376\000\001\003\000\001\377\377\377\377\377\003\000\001\377\377\377\377\377\377\377\003\377\377\377\377\377\377\377\377\377\377\376\377\372\000\000\000\000\200v\000\000\000\000h\\\377\377\377\377\357\376\000\001\003\000\001\377\377\377\377\377\377\377\003\377\377\377\377\377\377\377\377\377\377\377\003\377\377\377\377\377\377\377\377\377\377\376\377\372\000\000\000\000\200v\000\000\000\000h\\\377\377\377\377\357\376\000\001\003\000\001\377\377\377\377\377\377\377\003\377\377\377\377\377\377\377\377\377\377\376\377\372\007 artifact_prefix='./'; Test unit written to ./crash-2ea01576a6e0a74d403920761ea2ff6f0bf41752 Base64: /+/+AAEDAAH//////wMAAf////////8D//////////////7/+gAAAACAdgAAAABoXP/////v/gABAwAB/////////wP//////////////wP//////////////v/6AAAAAIB2AAAAAGhc/////+/+AAEDAAH/////////A//////////////+//oH Target ['/ci_container_base/ci/scratch/build/bitcoin-aarch64-unknown-linux-gnu/src/test/fuzz/fuzz', '-max_total_time=60'] failed with exit code 1

You can recreate the failures

Thanks a lot @fanquake, I managed to reproduce it this way (seeing that l0rinc#10 was failing, I was trying to run them manually instead of relying on the ci scripts).

why it isn't needed (or rather since when)

Thanks @maflcko for insisting, I have changed the order of commits to place the suppression removal at the very end since we still had a few failures for the first few commits - it's easier to remove them all at the end only, where I couldn't reproduce any such failure anymore.

Seems fine, but it may be better to remove the suppression in the exact commit that removes the need for it. This would make it easier to revert the commit atomically in one go, if there is need for whatever reason.

Any accounting inconsistency could've caused it to become negative and fail, so instead of removing these suppressions in the last commit that fixed the problem (giving the impression that it was just one change that enabled us removing it), I did it separately instead.
Is this important, is this holding back the ACK from your part?

…ddCoin`

This was added for the two branches to be symmetric and to explain why this branch is missing a subtraction. Co-authored-by: Andrew Toth <andrewstoth@gmail.com>

Assert that spent coins already have zero dynamic size, and remove unused leftover counter

Prevents the counter from dropping to 0 while cacheCoins still holds objects

…inserts Guarantees counter stays balanced both on insert and on in‑place replacement. Note that this is currently only called from AssumeUTXO code where it should only insert. Co-authored-by: Andrew Toth <andrewstoth@gmail.com>

These were fixed im previous commits: INFO: Seed: 3018625440 INFO: Loaded 1 modules (641435 inline 8-bit counters): 641435 [0x5810b64ebb78, 0x5810b6588513), INFO: Loaded 1 PC tables (641435 PCs): 641435 [0x5810b6588518,0x5810b6f51ec8), INFO: 1859 files found in /ci_container_base/ci/scratch/qa-assets/fuzz_corpora/coins_view INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 1005297 bytes INFO: seed corpus: files: 1859 min: 2b max: 1005297b total: 48403597b rss: 111Mb /ci_container_base/src/coins.cpp:133:22: runtime error: unsigned integer overflow: 0 - 64 cannot be represented in type 'size_t' (aka 'unsigned long') #0 0x5810b3768b67 in CCoinsViewCache::SpendCoin(COutPoint const&, Coin*) /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/./coins.cpp:133:22 #1 0x5810b3095ff0 in coins_view_fuzz_target(std::span<unsigned char const, 18446744073709551615ul>)::$_4::operator()() const /ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu/src/test/fuzz /./test/fuzz/coins_view.cpp:87:40 ... SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow /ci_container_base/src/coins.cpp:133:22

l0rinc · 2025-06-10T11:36:14Z

Rebased after fuzz conflicts, ready for review again.

andrewtoth reviewed Apr 20, 2025

View reviewed changes

l0rinc force-pushed the l0rinc/reenable-coins-sanitizers branch from 4bd4805 to 763be0a Compare April 20, 2025 20:59

l0rinc changed the title ~~RFC: Fix cachedCoinsUsage usages in CCoinsViewCache~~ coins: Fix cachedCoinsUsage usages in CCoinsViewCache Apr 20, 2025

DrahtBot added the UTXO Db and Indexes label Apr 20, 2025

l0rinc marked this pull request as ready for review April 20, 2025 21:06

This was referenced Apr 21, 2025

Draft: CCoinMap Experiments #32128

Closed

Use number of dirty cache entries in flush warnings/logs #31703

Open

validation: fetch block inputs on parallel threads 10% faster IBD #31132

Open

DrahtBot added the CI failed label Apr 28, 2025

l0rinc force-pushed the l0rinc/reenable-coins-sanitizers branch from 763be0a to a0468a8 Compare April 29, 2025 09:50

l0rinc changed the title ~~coins: Fix cachedCoinsUsage usages in CCoinsViewCache~~ coins: fix cachedCoinsUsage usages in CCoinsViewCache Apr 29, 2025

l0rinc changed the title ~~coins: fix cachedCoinsUsage usages in CCoinsViewCache~~ coins: fix cachedCoinsUsage accounting in CCoinsViewCache Apr 29, 2025

DrahtBot removed the CI failed label Apr 29, 2025

maflcko reviewed Apr 29, 2025

View reviewed changes

l0rinc force-pushed the l0rinc/reenable-coins-sanitizers branch from a0468a8 to 0feba07 Compare May 10, 2025 21:46

l0rinc mentioned this pull request May 16, 2025

refactor: reenable implicit-integer-sign-change check for serialize.h #32296

Merged

l0rinc requested review from fanquake, maflcko and andrewtoth May 21, 2025 13:45

l0rinc mentioned this pull request May 23, 2025

fuzz: Add target for coins database #32602

Merged

DrahtBot added the Needs rebase label Jun 5, 2025

l0rinc and others added 6 commits June 10, 2025 13:35

coins: check unspent‑overwrite before cachedCoinsUsage change in `A…

85979e2

…ddCoin`

coins: assert just-created-coin has no dynamic memory usage

abdb350

This was added for the two branches to be symmetric and to explain why this branch is missing a subtraction. Co-authored-by: Andrew Toth <andrewstoth@gmail.com>

coins: spent erase in CoinsViewCacheCursor must not change usage

6eb65df

Assert that spent coins already have zero dynamic size, and remove unused leftover counter

coins: reset cachedCoinsUsage in Flush() only after the map is cleared

a22fe4f

Prevents the counter from dropping to 0 while cacheCoins still holds objects

l0rinc force-pushed the l0rinc/reenable-coins-sanitizers branch from 0feba07 to c7d9c42 Compare June 10, 2025 11:35

DrahtBot removed the Needs rebase label Jun 10, 2025

DrahtBot mentioned this pull request Jul 9, 2025

coins: remove logic for spent-and-FRESH cache entries and writing non-DIRTY entries #30673

Closed

DrahtBot mentioned this pull request Jul 20, 2025

coins: remove SetFresh method from CCoinsCacheEntry #33018

Open

coins: fix cachedCoinsUsage accounting in CCoinsViewCache #32313

Are you sure you want to change the base?

coins: fix cachedCoinsUsage accounting in CCoinsViewCache #32313

Conversation

l0rinc commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Apr 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l0rinc May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l0rinc commented Apr 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l0rinc Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l0rinc May 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l0rinc commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coins: fix `cachedCoinsUsage` accounting in `CCoinsViewCache` #32313

coins: fix `cachedCoinsUsage` accounting in `CCoinsViewCache` #32313

l0rinc commented Apr 20, 2025 •

edited

Loading

DrahtBot commented Apr 20, 2025 •

edited

Loading

l0rinc May 6, 2025 •

edited

Loading

l0rinc Apr 30, 2025 •

edited

Loading

l0rinc May 4, 2025 •

edited

Loading

l0rinc commented Jun 10, 2025 •

edited

Loading