[28.x] Backports #31648
Merged
[28.x] Backports #31648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#31611 Rebased-From: b537a2c
This change resolves an issue where a missing space caused the value of
the `build_AR` variable to be concatenated with the "NM=" string. This
resulted in subsequent calls to `${AR}` and `${NM}` failing.
Github-Pull: bitcoin#31627
Rebased-From: 8a46286
…p2p_msgs Inspired by: 00c1dbd (bitcoin#31419) Github-Pull: bitcoin#31623 Rebased-From: f93f0c9
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31648. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
#31623 is a clean merge to both branches, so no need for a cherry-pick here |
248a95f to
77c13c7
Compare
willcl-ark
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
ACK 77c13c7
All commits look good to me.
I guess the commit title "[WIP] Update release notes" gets updated later during finalisation?
|
@willcl-ark I've just changed it here. |
stickies-v
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Github-Pull: bitcoin#31500 Rebased-From: f89f168
willcl-ark
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
libeventpackage on NetBSD #31500MINmacro to_TRACEPOINT_TEST_MINin log_raw_p2p_msgs #31623