leveldb: show non-default options during init #31644
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31644. ReviewsSee the guideline for information on the review process. ConflictsNo conflicts as of last run. |
64b1bf4 to
8af25b0
Compare
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
|
How is this useful? |
I've extended the description with more details. Details2025-01-16T10:47:35Z Opening LevelDB in /Users/lorinc/Library/Application Support/Bitcoin/blocks/index
2025-01-16T10:47:35Z Opened LevelDB successfully with options: options.compression=NoCompression, options.create_if_missing=true, options.max_file_size=33554432, options.paranoid_checks=true, options.write_buffer_size=524288, readoptions.fill_cache=false, readoptions.verify_checksums=true, writeoptions.sync=true
...
2025-01-16T10:47:51Z Opening LevelDB in /Users/lorinc/Library/Application Support/Bitcoin/chainstate
2025-01-16T10:47:51Z Opened LevelDB successfully with options: options.compression=NoCompression, options.create_if_missing=true, options.max_file_size=33554432, options.paranoid_checks=true, options.write_buffer_size=2097152, readoptions.fill_cache=false, readoptions.verify_checksums=true, writeoptions.sync=trueE.g. options.compression=NoCompression, options.create_if_missing=true, options.max_file_size=33554432, options.paranoid_checks=true, options.write_buffer_size=262144, readoptions.fill_cache=false, readoptions.verify_checksums=true, writeoptions.sync=trueLogging the non-default LevelDB options during initialization makes it easier to understand and debug database behavior. For example, the Logging these differences helps trace configuration changes, especially when command-line arguments (such as |
Example output: > Opened LevelDB successfully with options: options.compression=NoCompression, options.create_if_missing=true, options.max_file_size=33554432, options.paranoid_checks=true, options.write_buffer_size=524288, readoptions.fill_cache=false, readoptions.verify_checksums=true, writeoptions.sync=true
8af25b0 to
aac1585
Compare
To help with to debugging and traceability (in alignment with displaying other non-default args such as
Command-line arg: dbcache="10000") we can extend the LevelDB opening log with the used settings.To avoid showing booleans as e.g.
create_if_missing=1, I've added a localToStringlambda forbool.I wanted to use
util::Joinat the end, but couldn't find any way that I liked.Example output after the change: