The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31496.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

We want to completely remove the flags in the future since we're storing it redundantly (cc @andrewtoth), so this move is a nack from me.

As @l0rinc alluded, we don't really need flags at all anymore. A dirty entry is one that is spent or is FRESH. So, we only really need a binary state now, not a bitfield, so we can replace flags with an m_fresh boolean. IsDirty() can return coin.IsSpent() || m_fresh.

Ookay.. closing suggested follow-up PR due to unexpected welcome. 🙃

Well, what about a PR with that approach to remove the flags bitfield and replace with a boolean for fresh only?

Well, what about a PR with that approach to remove the flags bitfield and replace with a boolean for fresh only?

I'd prefer someone else more knowledgeable/active in this area take the initiative on such a transform.

I'd prefer someone else more knowledgeable/active in this area take the initiative on such a transform.

We can help with the reviews - or even with describing the problem in more detail, but removing the flags (as described by @andrewtoth above) would be a lot more meaningful than just moving the flags.