contrib: correct default build path in man pages #31255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `gen-manpages.py` script is unable to find the executables because it tries to search in `/bitcoin/src` when no custom `BUILDDIR` is set. With the new build process in place, the default build dir is now set to `/bitcoin/build`. Prior to this change, the script stopped with a `not found or not an executable` error. Now it generates the man pages without needing to explicitly set `BUILDDIR` variable.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31255. ReviewsSee the guideline for information on the review process. |
|
Thanks, however this is part of #30986. |
Oh I see, I will take a look at it, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gen-manpages.pyscript is unable to findthe executables because it tries to search in
/bitcoin/srcwhen no customBUILDDIRis set.With the new build process in place, the default
build dir is now set to
/bitcoin/build.Prior to this change, the script stopped with a
not found or not an executableerror. Now itgenerates the man pages without needing to
explicitly set
BUILDDIRvariable.