Skip to content

Conversation

itornaza
Copy link
Contributor

@itornaza itornaza commented Sep 28, 2024

This is an attempt to fix the issue #30978 .

To briefly summarize, @Sjors found that while compiling dependencies on macOS 15.0 the following "No such file or directory" are generated while these tools are installed.

$ cd depends
$ make
/bin/sh: command -v llvm-ranlib: No such file or directory
/bin/sh: command -v llvm-strip: No such file or directory
/bin/sh: command -v llvm-nm: No such file or directory
/bin/sh: command -v llvm-objdump: No such file or directory
/bin/sh: command -v dsymutil: No such file or directory

The proposed fix conditionally defines the necessary variables for these tools in the ./depends/Makefile when building on macOS. The rationale is described in more detail in #30978 (comment) as the Solution number 3.

Update 1:

It turns out that Xcode's make is not setting the flags that Gnu does as @hebasto described in #30978 (comment). So, to avoid any architectural changes in the depends directory that may lead to more confusion, the current patch manually sets the required flag in order for the above errors to be resolved.

cc @hebasto

@DrahtBot
Copy link
Contributor

DrahtBot commented Sep 28, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/30994.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

@fanquake
Copy link
Member

fanquake commented Oct 2, 2024

Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: #30978 (comment).

@itornaza itornaza marked this pull request as draft October 4, 2024 16:30
@itornaza
Copy link
Contributor Author

itornaza commented Oct 4, 2024

Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: #30978 (comment).

Yes, switched to draft until we have a better understanding of the issue.

@hebasto
Copy link
Member

hebasto commented Jan 10, 2025

Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: #30978 (comment).

Yes, switched to draft until we have a better understanding of the issue.

See #30978 (comment).

@itornaza itornaza force-pushed the ion-issue-30978 branch 2 times, most recently from 32aba7e to ba06659 Compare February 25, 2025 11:24
@itornaza
Copy link
Contributor Author

Rebased and updated the description.

The errors are now suppressed by setting a flag for make in the depends/hosts/darwin.mk that make implementation of Xcode does not, see #30978 (comment) and #30978 (comment).

@itornaza itornaza marked this pull request as ready for review February 25, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants