wallet: Fix error messages telling user to specify wallet #30912
Conversation
It is not clear which file was meant here.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
|
See #26990. |
Is this related? My problem was that I was asked to provide a filename when in reality a wallet name or maybe directory name is expected. That PR seems to address a different issue? |
|
Yes, this is a duplicate of the first commit in #26990 (might be good to provide review feedback there). |
|
As they both touch the same lines, I thought you may not have been aware of that pull and that the natural course of action would be to leave feedback there rather than both pulls proposing to improve the same message. If you disagree with that I apologize. |
I wasn't aware of the PR and actually agree with that, I just thought (already from the first comment) you wanted to say that the PRs are duplicates, as in addressing the same issue, which they are not. |
I'm not very familiar with the wallet and got confused by the error messages
Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path).Try adding "-rpcwallet=<filename>" option to bitcoin-cli command line.not knowing which filename to put here (some
wallet.datin the wallet's directory?), when actually, at least for newer wallets, just the wallet name is expected.