-
Notifications
You must be signed in to change notification settings - Fork 37.7k
fuzz: fix timeout in crypto_fschacha20poly1305
#30725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: fix timeout in crypto_fschacha20poly1305
#30725
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
I think it can be tested by replacing the --- a/src/test/fuzz/crypto_chacha20poly1305.cpp
+++ b/src/test/fuzz/crypto_chacha20poly1305.cpp
@@ -130,7 +130,7 @@ FUZZ_TARGET(crypto_fschacha20poly1305)
// data).
InsecureRandomContext rng(provider.ConsumeIntegral<uint64_t>());
- LIMITED_WHILE(provider.ConsumeBool(), 10000)
+ LIMITED_WHILE(true, 10000)
{
// Mode: Maybe this is a way to know whether a harness can have a possible timeout issue? cc: @maflcko |
Please cross-link to the issue (#30505) |
lgtm ACK 8dec4e1 |
https://cirrus-ci.com/task/6004238088667136?logs=ci#L5367
https://cirrus-ci.com/task/6249653828583424?logs=ci#L5217
|
cc: @stratospher |
Concept ACK. (running it locally, will ACK after that!) |
I think we did not have an issue with that yet, but anyway, I'll investigate it and follow-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 8dec4e1. saw similar coverage stats (these are from different machines, saw more similar from same machine).
- on branch
#3974498 REDUCE cov: 544 ft: 3788 corp: 250/22Kb lim: 4096 exec/s: 124 rss: 538Mb L: 95/573 MS: 5 ChangeByte-ChangeByte-EraseBytes-ChangeBinInt-InsertByte-
- on master
#3975366 REDUCE cov: 571 ft: 3993 corp: 279/51Kb lim: 4096 exec/s: 148 rss: 829Mb L: 3009/3818 MS: 1 EraseBytes-
Fixes #30505
This PR fixes a timeout in
crypto_fschacha20poly1305
by reducing the number of iterations. I left it running for a while and noticed it speeds up the target and do not impact coverage.