Pre-28.x branch off version bump and doc updates #30719
Conversation
achow101
commented
Aug 26, 2024
- Bump to 28.99 in preparation for the 28.x branching
- Remove current release note fragments. They've been moved to draft release notes in the wiki.
- Updated bips.md with missing BIPs that were implemented a while ago.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
| @@ -1,2 +0,0 @@ | |||
| - Additional flags "in" and "out" have been added to `-whitelist` to control whether | |||
There was a problem hiding this comment.
nit: Adjusted this in the Wiki Page. Line wrap issue. Also moved to P2P section.
| @@ -1,2 +0,0 @@ | |||
| - unix socket paths are now accepted for `-zmqpubrawblock` and `-zmqpubrawtx` with | |||
There was a problem hiding this comment.
nit: Adjusted this in the Wiki Page. Line wrap issue.
This should be post-branching...? |
I don't think it particularly matters since that step has to be done in the 28.x branch too, in addition to the other version numbers being bumped. |
During the previous release cycle, it was done just after the branching off. UPD. I agree that it does not really matter. |
Added to the wiki, but still needs to be removed here. |
Good catch, removed it. |
|
ACK d3fd608 after typo fix |
|
lgtm ACK 1bf9b70 |
fa3a7eb lint: Check for release note snippets in the wrong folder (MarcoFalke) Pull request description: It is a common mistake to place the snippets in the wrong folder, where they could be missed. For example #30719 (review) or commit 84900ac. Fix all issues by adding a simple lint check. Can be tested by reverting a prior commit that violated the rule and then running the new check: ``` git revert 35ef34e ( cd ./test/lint/test_runner/ && RUST_BACKTRACE=1 cargo run -- --lint=doc_release_note_snippets ) ACKs for top commit: l0rinc: ACK fa3a7eb TheCharlatan: Re-ACK fa3a7eb Tree-SHA512: 65a13696178aa8f94daa12a767cc74861293c631c19da9ca23c0fd43cedd47e7928d0ef14ad9ad83a434c1ac0e006f5a632ba9679756e071dea65b3cbf927c2d