Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Aug 10, 2024

This problematic nTx "faking" was removed in commit b50554b.

So fix the wrong comment.

Also, address the typo nits from:

This was fixed in commit b50554b.

Also, address the typo nits from:

* bitcoin#29370 (comment)
* bitcoin#30598 (comment)
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 10, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fjahr

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fjahr
Copy link
Contributor

fjahr commented Aug 10, 2024

ACK fa04511

@fanquake fanquake merged commit 40c11ac into bitcoin:master Aug 12, 2024
16 checks passed
@maflcko maflcko deleted the 2408-doc-ntx-no-fake branch August 12, 2024 12:13
@bitcoin bitcoin locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants