doc: Change nproc in docs to getconf _NPROCESSORS_ONLN
#30619
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
nproc in docs to getconf _NPROCESSORS_ONLNnproc in docs to getconf _NPROCESSORS_ONLN
There was a problem hiding this comment.
Reviewed 6d7bf8e
Long-time devs state how MacOS is not a supported development platform, and this change does make things more verbose, so I'm curious to get their take. But I'm happy to see there is a way that works for both.
Verified that it does seem to be the right identifier to query by reading: https://www.gnu.org/software/libc/manual/html_node/Processor-Resources.html
You are not changing doc/fuzzing.md which was linked in #30619 (comment)?
nproc is linux only, getconf _NPROCESSORS_ONLN is used in the Linux kernel for the same task: https://github.com/torvalds/linux/blob/master/tools/testing/selftests/rcutorture/bin/kvm-build.sh#L44 Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>
6d7bf8e to
7f8e80b
Compare
I don't think this is true. I don't have a mac, but I fail to see why installing it won't work. Also, a bash alias similar to No objection to changing this, but I think the claim that |
|
Thanks @maflcko, I would actually prefer mentioning nproc (+ alternatives) only once in the docs - will be easier after the cmake PR updates are merged. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
it is true that |
Yeah, would require more thorough doc updates to clarify that - agree, not worth it |
|
Just for reference, the change would be wrong anyway, because the two are used to return different values |
|
Yeah, I hated how verbose that was. |
Split out of https://github.com/hebasto/bitcoin/pull/316/files#r1711537463
nprocis linux only,getconf _NPROCESSORS_ONLNis used in the Linux kernel for the same task (works on Mac as well): https://github.com/torvalds/linux/blob/master/tools/testing/selftests/rcutorture/bin/kvm-build.sh#L44On linux:
Note that in the productivity doc the recommended core count is one less than before, seems simpler to me this way.