ci: Silent Homebrew's reinstall warnings #30591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
tdb3
approved these changes
Aug 7, 2024
fanquake
reviewed
Aug 12, 2024
| @@ -104,8 +104,8 @@ jobs: | |||
| HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1 | |||
| run: | | |||
| # A workaround for "The `brew link` step did not complete successfully" error. | |||
| brew install python@3 || brew link --overwrite python@3 | |||
| brew install automake libtool pkg-config gnu-getopt ccache boost libevent miniupnpc libnatpmp zeromq qt@5 qrencode | |||
| brew install --quiet python@3 || brew link --overwrite python@3 | |||
There was a problem hiding this comment.
Are these Qt workarounds still needed? Would be good if we could drop them, rather than adding more code to suppress warnings coming from workarounds that may no-longer be needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew's warnings are quite noisy on the master branch:
This PR silents them to allow us to focus on other CI infra warnings once they happen.
Similar to bitcoin-core/secp256k1#1578.