Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 3, 2024

CMake is used to build the following packages in depends when cross-compiling for Windows:

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 3, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan, tdb3, vostrnad, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ee934d0

Copy link
Contributor

@tdb3 tdb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cr ut ACK ee934d0

@vostrnad
Copy link

vostrnad commented Aug 4, 2024

ACK ee934d0

nit: PR description could explain why it was missing. I've used these build instructions before and I know they worked.

@hebasto
Copy link
Member Author

hebasto commented Aug 4, 2024

@vostrnad

nit: PR description could explain why it was missing.

The list of packages that use CMake has been added to the PR description.

I've used these build instructions before and I know they worked.

Your system might already have CMake installed. However, this is generally not a safe assumption, for instance, for Docker images.

@vostrnad
Copy link

vostrnad commented Aug 4, 2024

@hebasto That might be it, I previously used these instructions successfully with Ubuntu WSL and only had cmake missing after switching to Debian WSL. I guess Ubuntu had it preinstalled.

@achow101
Copy link
Member

achow101 commented Aug 5, 2024

ACK ee934d0

@achow101 achow101 merged commit 2917f41 into bitcoin:master Aug 5, 2024
16 checks passed
@bitcoin bitcoin locked and limited conversation to collaborators Aug 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants