Skip to content

remove truc_policy from libbitcoin_common_a_SOURCES #30427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

remove truc_policy from libbitcoin_common_a_SOURCES #30427

merged 1 commit into from
Jul 11, 2024

Conversation

glozow
Copy link
Member

@glozow glozow commented Jul 11, 2024

Hebasto pointed out that it doesn't need to be there since it's in libbitcoin_node_a_SOURCES

@glozow @hebasto
remove truc_policy.cpp from libbitcoin_common_a_SOURCES
e8c3b71 
It doesn't need it

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 11, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, ismaelsadeeq, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@maflcko
Copy link
Member

maflcko commented Jul 11, 2024

In theory libbitcoin_wallet may want to use it at some point? Though, I guess it can be moved back then, if needed.

@hebasto
Copy link
Member

hebasto commented Jul 11, 2024 •
edited
Loading

In theory libbitcoin_wallet may want to use it at some point? Though, I guess it can be moved back then, if needed.

If/when it happens, the policy/truc_policy.cpp source file can be moved from libbitcoin_node.a to the libbitcoin_common.a static library sources.

hebasto
hebasto approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e8c3b71, this change follows the design docs.

ismaelsadeeq
ismaelsadeeq reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@ismaelsadeeq ismaelsadeeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e8c3b71

@maflcko
Copy link
Member

maflcko commented Jul 11, 2024

ACK e8c3b71

@fanquake fanquake merged commit e5a5497 into bitcoin:master Jul 11, 2024
@glozow glozow deleted the 2024-07-truc-common branch July 12, 2024 10:13
@hebasto hebasto mentioned this pull request Jul 14, 2024
Closed
@hebasto
Copy link
Member

hebasto commented Jul 14, 2024

Ported to the CMake-based build system in hebasto#264.

@bitcoin bitcoin locked and limited conversation to collaborators Jul 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

+1 more reviewer

@ismaelsadeeq ismaelsadeeq ismaelsadeeq left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glozow @DrahtBot @maflcko @hebasto @ismaelsadeeq @fanquake