contrib: use c++ compiler rather than c compiler for binary checks #30387

theuni · 2024-07-04T00:48:36Z

From hebasto's CMake repo. See discussion here: hebasto#252 (comment)

Use CXX/CXXFLAGS rather than CC/CFLAGS to test our actual compiler for binary checks rather than the one we only forward to secp256k1.

DrahtBot · 2024-07-04T00:48:39Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	hebasto, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#30423 (contrib: simplify test-security-check by fanquake)
#27038 (security-check: test for _FORTIFY_SOURCE usage in release binaries by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto · 2024-07-04T09:07:46Z

Use CXX/CXXFLAGS rather than CC/CFLAGS to test our actual compiler for binary checks rather than the one we only forward to secp256k1.

Concept ACK on that.

From hebasto's CMake repo. See discussion here: hebasto#252 (comment)

While the discussion was raised in the CMake project, I'd like to note that this change is not required for it. However, the CMake project's implementation depends on this PR.

DrahtBot · 2024-07-04T12:58:09Z

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit `3714692` (master)	commit `3c8ae9f` (master and this pull)
SHA256SUMS.part	`d41c7d41da575672...`	`829f749d8e9d9291...`
*-aarch64-linux-gnu-debug.tar.gz	`f7897c27a1d2ced4...`	`752b54f93c7a4a97...`
*-aarch64-linux-gnu.tar.gz	`18bb14e300355588...`	`0d9dd43ce855883b...`
*-arm-linux-gnueabihf-debug.tar.gz	`b3a532343e46beb5...`	`ebae117737f31eb0...`
*-arm-linux-gnueabihf.tar.gz	`81a760da1d4ab412...`	`49632047ddd9a441...`
*-arm64-apple-darwin-unsigned.tar.gz	`070a3855d640a915...`	`b54e9deda9887c13...`
*-arm64-apple-darwin-unsigned.zip	`6ae4adba654de987...`	`96ed754c507c1006...`
*-arm64-apple-darwin.tar.gz	`29173dc0eff64a18...`	`fce87d809244ec40...`
*-powerpc64-linux-gnu-debug.tar.gz	`b7aebe8bc1ebb018...`	`20bb5242cf6834e0...`
*-powerpc64-linux-gnu.tar.gz	`b98a53be49a46a34...`	`04acbd61aee7d764...`
*-riscv64-linux-gnu-debug.tar.gz	`697f47773a0f543d...`	`ca3aac67fa562e62...`
*-riscv64-linux-gnu.tar.gz	`d03f94ad770d885c...`	`29f01dbdce7cdacb...`
*-x86_64-apple-darwin-unsigned.tar.gz	`bb7d800856a9ab70...`	`c738537791d55571...`
*-x86_64-apple-darwin-unsigned.zip	`44905a4c82c02b38...`	`a78b0730b194daf4...`
*-x86_64-apple-darwin.tar.gz	`d3ec6e7f9187097f...`	`1778dd05872182cb...`
*-x86_64-linux-gnu-debug.tar.gz	`0a7e1ee671d4599c...`	`f32406f3487ede58...`
*-x86_64-linux-gnu.tar.gz	`f08b8a57703e94d2...`	`9fb0bc023d8543b7...`
*.tar.gz	`05a1b03d4c612d47...`	`68d44148ba75ed22...`
guix_build.log	`7ea72927f335e155...`	`aedcdef7094e6084...`
guix_build.log.diff		`ddecbfe38841329d...`

hebasto · 2024-07-04T13:12:49Z

My Guix build:

x86_64
33e4e9bba968ed9ee96f67a8535b71bc1b1c5ede7038a2b636f406262474ddca  guix-build-98ff3703b81f/output/aarch64-linux-gnu/SHA256SUMS.part
d670e9a8cc34c7b8e9567ee8654b5323ee102e18cbbd53d541deae779100f344  guix-build-98ff3703b81f/output/aarch64-linux-gnu/bitcoin-98ff3703b81f-aarch64-linux-gnu-debug.tar.gz
8a96d7fb1539524b8d29eb768cf3d4ed2428df203fba3bce0ff173b733cb8d51  guix-build-98ff3703b81f/output/aarch64-linux-gnu/bitcoin-98ff3703b81f-aarch64-linux-gnu.tar.gz
d0e0d95561427154082def7876ffab0af623434bd560fee2abbed4c83fe33d9c  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/SHA256SUMS.part
8790f82d3810aaf07fa72062074daf8ac65bf42316a4521ee3a068647ea1aae2  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/bitcoin-98ff3703b81f-arm-linux-gnueabihf-debug.tar.gz
2a9b099feb1f962ff7680f5a750713d292758d140c63698fddc14c2482937e67  guix-build-98ff3703b81f/output/arm-linux-gnueabihf/bitcoin-98ff3703b81f-arm-linux-gnueabihf.tar.gz
4d1db0f3aa39c100a991056950a07593aa9e65b35b5412faddc50fae560de4c1  guix-build-98ff3703b81f/output/arm64-apple-darwin/SHA256SUMS.part
23e03471b7ab74326b2f61ce4b35c5aa20e2890769da1d98f3d5d7c7193d7516  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin-unsigned.tar.gz
5c45236ecf9b0c6159e27d4448723be8eb68fdf1a9117ce9bded3744ef2c4b1a  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin-unsigned.zip
45885dbedd8281b22e3ddb755eaee84ec663a73c31e157812c714145f786f335  guix-build-98ff3703b81f/output/arm64-apple-darwin/bitcoin-98ff3703b81f-arm64-apple-darwin.tar.gz
6b0da9684b9a5859ead9c7bd25726981a90b6f7fd4be73163b536c7530726ea9  guix-build-98ff3703b81f/output/dist-archive/bitcoin-98ff3703b81f.tar.gz
5b3f4865f3364d199c1576e407037e048ddfe2f93f98f48df18dfce42c1f175e  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/SHA256SUMS.part
4980bdc614462e55ccd68e3178d1e5ad1f1e25f333d1e7b6f1b046c5609f2a92  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/bitcoin-98ff3703b81f-powerpc64-linux-gnu-debug.tar.gz
ec4860223d80225f6b4685ba98c7543bc3dec943dfab6ac4d5e5b175ed1eb684  guix-build-98ff3703b81f/output/powerpc64-linux-gnu/bitcoin-98ff3703b81f-powerpc64-linux-gnu.tar.gz
0554ff03b10b32c75cbc35c4720d8b430a7a74efcfd4b5b921188d590bf7b655  guix-build-98ff3703b81f/output/riscv64-linux-gnu/SHA256SUMS.part
419c9b417c7acc80cc630983ae6c3719665d4cc9e81f127ea32e6731f210ff0d  guix-build-98ff3703b81f/output/riscv64-linux-gnu/bitcoin-98ff3703b81f-riscv64-linux-gnu-debug.tar.gz
a8061147d63315222e44cd835f700be982a47daaaf6f3b17f1c9846e91898e69  guix-build-98ff3703b81f/output/riscv64-linux-gnu/bitcoin-98ff3703b81f-riscv64-linux-gnu.tar.gz
9dc82d3d8309408323240f4ee33c4285f24f6c92bf749f035fce7aad948abe2c  guix-build-98ff3703b81f/output/x86_64-apple-darwin/SHA256SUMS.part
691389f8d49485b7918e780f4824e27384994a8d71baba03075ec616d7da012e  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin-unsigned.tar.gz
bb85b07f7d8487a069e64a18325eba27f7e32128e8f17224f44aa38e6f7a9673  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin-unsigned.zip
45c0ef2485906f55858177ed11a6ef881c77675e9cf252d7fa8214a840b07479  guix-build-98ff3703b81f/output/x86_64-apple-darwin/bitcoin-98ff3703b81f-x86_64-apple-darwin.tar.gz
ae23df193d78011cf9c67346c4e410c9c5b023140d8d16ffdfed172848fe4b07  guix-build-98ff3703b81f/output/x86_64-linux-gnu/SHA256SUMS.part
3a3600cf67dd3e34b402e2d140ea7b6d8bc881a1a929ccde167072f43ae86e01  guix-build-98ff3703b81f/output/x86_64-linux-gnu/bitcoin-98ff3703b81f-x86_64-linux-gnu-debug.tar.gz
f41075bf832bd0a05d458f756983f993ce703e04f3a530268386c66ddb440f85  guix-build-98ff3703b81f/output/x86_64-linux-gnu/bitcoin-98ff3703b81f-x86_64-linux-gnu.tar.gz
9ec320d7e496e5bc6ad34f2e388a13b02161b5308ca8fc4c467ea771ccbd3780  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/SHA256SUMS.part
0e9c003212e5f9cb3e005472b75d68dd86f10a005bcdf9bd8b1c9af40364cf81  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-debug.zip
c39f2f213590c95d6dbe098b8e18a34d3ad0a531884c5a5e41141b927c5aa0a3  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-setup-unsigned.exe
d3a5158a714c843c15146c13a85829f08e4bca2d969f06ec5998814a1af592b0  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64-unsigned.tar.gz
cac0c37a2d8baf280c8235fee992f9176e2f7f8be32a321053cd4bec069511e6  guix-build-98ff3703b81f/output/x86_64-w64-mingw32/bitcoin-98ff3703b81f-win64.zip

hebasto

ACK 98ff370, I have reviewed the code and it looks OK. The Guix build script works as expected..

fanquake · 2024-07-04T13:29:36Z

Concept ACK - probably also the right time to switch the C code to something more C++. i.e:

#include <stdio.h>
int main() {
        printf("the quick brown fox jumps over the lazy god\\n");
        return 0;
}

to

#include <cstdio>
int main() {
	std::printf("the quick brown fox jumps over the lazy god\n");
        return 0;
}

Makefile.am

We don't actually use a c compiler as part of Core's build (only for secp). We should be testing against what we're actually using instead.

TheCharlatan · 2024-07-05T09:49:16Z

Getting a check failure during a guix build:

.
----------------------------------------------------------------------
Ran 1 test in 5.525s

OK
F
======================================================================
FAIL: test_ELF (__main__.TestSymbolChecks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/distsrc-base/distsrc-dae34eb480c8-arm-linux-gnueabihf/./contrib/devtools/test-symbol-check.py", line 69, in test_ELF
    self.assertEqual(call_symbol_check(cxx, source, executable, []),
AssertionError: Tuples differ: (1, 'test3: export of symbol __cxa_begin_c[216 chars]OLS') != (0, '')

First differing element 0:
1
0

+ (0, '')
- (1,
-  'test3: export of symbol __cxa_begin_cleanup not allowed!\n'
-  'test3: export of symbol __cxa_call_unexpected not allowed!\n'
-  'test3: export of symbol __aeabi_atexit not allowed!\n'
-  'test3: export of symbol __cxa_type_match not allowed!\n'
-  'test3: failed EXPORTED_SYMBOLS')

----------------------------------------------------------------------
Ran 1 test in 1.004s

FAILED (failures=1)
make: *** [Makefile:1351: test-security-check] Error 1

hebasto · 2024-07-11T10:14:11Z

Getting a check failure during a guix build:

I think we should avoid #include <iostream> in our test stubs, which

behaves as if it defines a static storage duration object...

contrib/devtools/test-symbol-check.py

contrib/devtools/test-security-check.py

hebasto

ACK 9010b13.

My Guix build:

x86_64
77365de6a5a0dd40d79f2c4ba8ac8f105c44348076ef64eb36c9ae030ce833f8  guix-build-9010b1343b9f/output/aarch64-linux-gnu/SHA256SUMS.part
af1b2f2cd45ce3b510903c674d68545e0ec0ad4cb5b7e65b7e6e8f17eabb4f4f  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu-debug.tar.gz
a88c00e179e1302a3ffd438c175b2f6331b58f0484757c1f843ca2d2a386fd59  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu.tar.gz
bf1763fd485bd84585d5793348abe8e7e9d0bed245d01fb8a3df1639d77a90ab  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/SHA256SUMS.part
982aea1f79f9ba0ec39563bcd18d0cfff187eb1dd089b543da6ec208552c7b4f  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf-debug.tar.gz
b9b91132a3ae437a53840d96f0bd3a36986251600243638eab481aeb73acb78c  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf.tar.gz
5971881d40d0357a67185f17a7416d98e2ffdcfea612991f06c83c02e8514828  guix-build-9010b1343b9f/output/arm64-apple-darwin/SHA256SUMS.part
66c1e765885f3dac977208025b169a9f7a12cdb3b474bb87a7703c6a9bbb3cd7  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.tar.gz
fd5c497dc98eb38e13c37d67fb19845b8fdaed5e98503bbc62b89fc5ae4c080f  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.zip
c736677cdf4c164550b1dbac82de2fff8f85880a48ec75894a813b1dc46a2741  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin.tar.gz
2242e3da93ca6baf06643127669cbba377b64b5de9073a1ce4be52e611f34cf4  guix-build-9010b1343b9f/output/dist-archive/bitcoin-9010b1343b9f.tar.gz
55b4104744d48f8d632fac313792e89aa75d89608632115b0214b6c0633482db  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/SHA256SUMS.part
9f9c3b89510974f08380113e6c30e644058e96650cd05e9f34935d54fdbcb405  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu-debug.tar.gz
8f57a0489292c542cf20406c474f6d6f7c6c3cac27983722df6382534669e5a4  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu.tar.gz
2c09aae42ba4b37cd146984eae1f7f6d7a6f37fe6b62568a2f6ec0f1e3b18c47  guix-build-9010b1343b9f/output/riscv64-linux-gnu/SHA256SUMS.part
a34b7bf6e240dada36ba031068bb8145142749659865f2394dcb018703e8cd0c  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu-debug.tar.gz
901f86eca2a038c0e1aae9b3a1ac21d49952604bfe7f49f5b1e4c3d52a1d8322  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu.tar.gz
c43c381562d7e3c4705d22ed759258c60e5cc2d18c317563669e4710e0c980e1  guix-build-9010b1343b9f/output/x86_64-apple-darwin/SHA256SUMS.part
6da70cdabaa4d347c517a5bc73f68ca64487ea6d39a98400979f776acd089519  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.tar.gz
6167d2e284305345abbd3d0bf78bb3c1e9a1e83592ddb0ba423a741d77067cbe  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.zip
af663e49542cdfb0b5f27cdd687e94744b8a1c5fee5ca9612afbfb5b4ef7713b  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin.tar.gz
93d2fe4810d4e85ec616927f9f9cb4da5dae3bd049c0e1b0a0f238c0defe47af  guix-build-9010b1343b9f/output/x86_64-linux-gnu/SHA256SUMS.part
5a3acd323aaef9973578bd70eadef6c47999362f2437b4a17a74ccaa38f09479  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu-debug.tar.gz
e17960a39e6499265c47f4bdd098e5be287677c56cb0e98acfd432088055964e  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu.tar.gz
2c96ce22a6ef5a4b3cde7ba594acc9247029602219ac5cafd39442f6e3a2493f  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/SHA256SUMS.part
5a1573063f333eef59ff6010a6c7618349899b920112f2d2d42a62f91cb0923a  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-debug.zip
d61cbcf3152333caf54a2b168a3e94aa9a604cec81e53d8aeef7ee553977a92c  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-setup-unsigned.exe
9ff74a859b4ab8f758ccddeae032fc14402149c39cb32fd11d58ad7ea2bdeae0  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-unsigned.tar.gz
b4525271b451180a7bf3e9954d8ddc79af98a36b69c534c8b35158bc7dce99b5  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64.zip

DrahtBot · 2024-07-12T04:58:33Z

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit `33af14e` (master)	commit `81d9306` (master and this pull)
SHA256SUMS.part	`d8e5b36649e40a4c...`	`df788fcb86c4274c...`
*-aarch64-linux-gnu-debug.tar.gz	`5a47f15b9408d7f4...`	`05e7f80e72b19299...`
*-aarch64-linux-gnu.tar.gz	`41241ef7c8f4ed1b...`	`02816fac5725840e...`
*-arm-linux-gnueabihf-debug.tar.gz	`51821eca108d3504...`	`d8d2a81e0d7df001...`
*-arm-linux-gnueabihf.tar.gz	`ba65286caa7fdc0a...`	`5aa7d41a19c0602b...`
*-arm64-apple-darwin-unsigned.tar.gz	`024035dab6cb8a97...`	`342d959e8eb84ffe...`
*-arm64-apple-darwin-unsigned.zip	`16124af5c06e1c50...`	`1d5dc3981b6405e7...`
*-arm64-apple-darwin.tar.gz	`1bf1df820984af09...`	`e8e868bed7da8292...`
*-powerpc64-linux-gnu-debug.tar.gz	`3d9ad6d234e0992a...`	`848431d8788a8911...`
*-powerpc64-linux-gnu.tar.gz	`d674464cfef17d7e...`	`8ead7849bd40dea9...`
*-riscv64-linux-gnu-debug.tar.gz	`a7b724f2f3e3b585...`	`d39972da71861eb1...`
*-riscv64-linux-gnu.tar.gz	`53fcfce9ca89f53b...`	`56f8f5b5f157e064...`
*-x86_64-apple-darwin-unsigned.tar.gz	`c38525b75b917ec4...`	`5956af410cae9f37...`
*-x86_64-apple-darwin-unsigned.zip	`e0a8f6b7b4ff43ed...`	`2f84fca3a7b268e2...`
*-x86_64-apple-darwin.tar.gz	`c54321f27f5db6cb...`	`708983f5d0b6450c...`
*-x86_64-linux-gnu-debug.tar.gz	`ba152c8170e75643...`	`2e6c608db9f696a4...`
*-x86_64-linux-gnu.tar.gz	`67d87654a67da03d...`	`0933440158e10676...`
*.tar.gz	`0c8407c13e7f0586...`	`581927276a91f882...`
guix_build.log	`06e67ba18f4bb03d...`	`573d30013d954320...`
guix_build.log.diff		`2e145ed8023a92e0...`

fanquake

ACK 9010b13

Guix Build (aarch64):

77365de6a5a0dd40d79f2c4ba8ac8f105c44348076ef64eb36c9ae030ce833f8  guix-build-9010b1343b9f/output/aarch64-linux-gnu/SHA256SUMS.part
af1b2f2cd45ce3b510903c674d68545e0ec0ad4cb5b7e65b7e6e8f17eabb4f4f  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu-debug.tar.gz
a88c00e179e1302a3ffd438c175b2f6331b58f0484757c1f843ca2d2a386fd59  guix-build-9010b1343b9f/output/aarch64-linux-gnu/bitcoin-9010b1343b9f-aarch64-linux-gnu.tar.gz
bf1763fd485bd84585d5793348abe8e7e9d0bed245d01fb8a3df1639d77a90ab  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/SHA256SUMS.part
982aea1f79f9ba0ec39563bcd18d0cfff187eb1dd089b543da6ec208552c7b4f  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf-debug.tar.gz
b9b91132a3ae437a53840d96f0bd3a36986251600243638eab481aeb73acb78c  guix-build-9010b1343b9f/output/arm-linux-gnueabihf/bitcoin-9010b1343b9f-arm-linux-gnueabihf.tar.gz
5971881d40d0357a67185f17a7416d98e2ffdcfea612991f06c83c02e8514828  guix-build-9010b1343b9f/output/arm64-apple-darwin/SHA256SUMS.part
66c1e765885f3dac977208025b169a9f7a12cdb3b474bb87a7703c6a9bbb3cd7  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.tar.gz
fd5c497dc98eb38e13c37d67fb19845b8fdaed5e98503bbc62b89fc5ae4c080f  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin-unsigned.zip
c736677cdf4c164550b1dbac82de2fff8f85880a48ec75894a813b1dc46a2741  guix-build-9010b1343b9f/output/arm64-apple-darwin/bitcoin-9010b1343b9f-arm64-apple-darwin.tar.gz
2242e3da93ca6baf06643127669cbba377b64b5de9073a1ce4be52e611f34cf4  guix-build-9010b1343b9f/output/dist-archive/bitcoin-9010b1343b9f.tar.gz
55b4104744d48f8d632fac313792e89aa75d89608632115b0214b6c0633482db  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/SHA256SUMS.part
9f9c3b89510974f08380113e6c30e644058e96650cd05e9f34935d54fdbcb405  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu-debug.tar.gz
8f57a0489292c542cf20406c474f6d6f7c6c3cac27983722df6382534669e5a4  guix-build-9010b1343b9f/output/powerpc64-linux-gnu/bitcoin-9010b1343b9f-powerpc64-linux-gnu.tar.gz
2c09aae42ba4b37cd146984eae1f7f6d7a6f37fe6b62568a2f6ec0f1e3b18c47  guix-build-9010b1343b9f/output/riscv64-linux-gnu/SHA256SUMS.part
a34b7bf6e240dada36ba031068bb8145142749659865f2394dcb018703e8cd0c  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu-debug.tar.gz
901f86eca2a038c0e1aae9b3a1ac21d49952604bfe7f49f5b1e4c3d52a1d8322  guix-build-9010b1343b9f/output/riscv64-linux-gnu/bitcoin-9010b1343b9f-riscv64-linux-gnu.tar.gz
c43c381562d7e3c4705d22ed759258c60e5cc2d18c317563669e4710e0c980e1  guix-build-9010b1343b9f/output/x86_64-apple-darwin/SHA256SUMS.part
6da70cdabaa4d347c517a5bc73f68ca64487ea6d39a98400979f776acd089519  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.tar.gz
6167d2e284305345abbd3d0bf78bb3c1e9a1e83592ddb0ba423a741d77067cbe  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin-unsigned.zip
af663e49542cdfb0b5f27cdd687e94744b8a1c5fee5ca9612afbfb5b4ef7713b  guix-build-9010b1343b9f/output/x86_64-apple-darwin/bitcoin-9010b1343b9f-x86_64-apple-darwin.tar.gz
93d2fe4810d4e85ec616927f9f9cb4da5dae3bd049c0e1b0a0f238c0defe47af  guix-build-9010b1343b9f/output/x86_64-linux-gnu/SHA256SUMS.part
5a3acd323aaef9973578bd70eadef6c47999362f2437b4a17a74ccaa38f09479  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu-debug.tar.gz
e17960a39e6499265c47f4bdd098e5be287677c56cb0e98acfd432088055964e  guix-build-9010b1343b9f/output/x86_64-linux-gnu/bitcoin-9010b1343b9f-x86_64-linux-gnu.tar.gz
2c96ce22a6ef5a4b3cde7ba594acc9247029602219ac5cafd39442f6e3a2493f  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/SHA256SUMS.part
5a1573063f333eef59ff6010a6c7618349899b920112f2d2d42a62f91cb0923a  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-debug.zip
d61cbcf3152333caf54a2b168a3e94aa9a604cec81e53d8aeef7ee553977a92c  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-setup-unsigned.exe
9ff74a859b4ab8f758ccddeae032fc14402149c39cb32fd11d58ad7ea2bdeae0  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64-unsigned.tar.gz
b4525271b451180a7bf3e9954d8ddc79af98a36b69c534c8b35158bc7dce99b5  guix-build-9010b1343b9f/output/x86_64-w64-mingw32/bitcoin-9010b1343b9f-win64.zip

DrahtBot added the Scripts and tools label Jul 4, 2024

theuni added the DrahtBot Guix build requested label Jul 4, 2024

Tina1L approved these changes Jul 4, 2024

View reviewed changes

DrahtBot mentioned this pull request Jul 4, 2024

security-check: test for _FORTIFY_SOURCE usage in release binaries #27038

Merged

DrahtBot removed the DrahtBot Guix build requested label Jul 4, 2024

hebasto approved these changes Jul 4, 2024

View reviewed changes

TheCharlatan reviewed Jul 4, 2024

View reviewed changes

Makefile.am Outdated Show resolved Hide resolved

theuni added 2 commits July 4, 2024 20:16

contrib: use c++ rather than c for binary tests

a38c960

We don't actually use a c compiler as part of Core's build (only for secp). We should be testing against what we're actually using instead.

contrib: rename cc to cxx in binary checking scripts

261f770

theuni force-pushed the cxx-security-check branch from 98ff370 to 261f770 Compare July 4, 2024 20:16

DrahtBot mentioned this pull request Jul 11, 2024

contrib: simplify test-security-check #30423

Merged

hebasto reviewed Jul 11, 2024

View reviewed changes

contrib/devtools/test-symbol-check.py Outdated Show resolved Hide resolved

contrib/devtools/test-symbol-check.py Outdated Show resolved Hide resolved

theuni force-pushed the cxx-security-check branch from dae34eb to dc4dfd2 Compare July 11, 2024 14:13

DrahtBot added the CI failed label Jul 11, 2024

hebasto reviewed Jul 11, 2024

View reviewed changes

contrib/devtools/test-security-check.py Outdated Show resolved Hide resolved

contrib: c++ify test stubs after switching to c++ compilers

9010b13

theuni force-pushed the cxx-security-check branch from dc4dfd2 to 9010b13 Compare July 11, 2024 17:29

fanquake added the DrahtBot Guix build requested label Jul 11, 2024

hebasto mentioned this pull request Jul 11, 2024

cmake: Enable C language in the root CMakeLists.txt hebasto/bitcoin#252

Merged

hebasto approved these changes Jul 11, 2024

View reviewed changes

DrahtBot requested a review from fanquake July 11, 2024 19:55

DrahtBot removed the DrahtBot Guix build requested label Jul 12, 2024

DrahtBot removed the CI failed label Jul 12, 2024

fanquake approved these changes Jul 16, 2024

View reviewed changes

fanquake merged commit 5f538f2 into bitcoin:master Jul 16, 2024

bitcoin locked and limited conversation to collaborators Jul 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

contrib: use c++ compiler rather than c compiler for binary checks #30387

contrib: use c++ compiler rather than c compiler for binary checks #30387

Uh oh!

theuni commented Jul 4, 2024 •

edited

Loading

Uh oh!

DrahtBot commented Jul 4, 2024 •

edited

Loading

Uh oh!

hebasto commented Jul 4, 2024 •

edited

Loading

Uh oh!

DrahtBot commented Jul 4, 2024

Uh oh!

hebasto commented Jul 4, 2024

Uh oh!

hebasto left a comment

Uh oh!

fanquake commented Jul 4, 2024

Uh oh!

Uh oh!

TheCharlatan commented Jul 5, 2024

Uh oh!

hebasto commented Jul 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hebasto left a comment

Uh oh!

DrahtBot commented Jul 12, 2024

Uh oh!

fanquake left a comment

Uh oh!

Uh oh!

contrib: use c++ compiler rather than c compiler for binary checks #30387

contrib: use c++ compiler rather than c compiler for binary checks #30387

Uh oh!

Conversation

theuni commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Conflicts

Uh oh!

hebasto commented Jul 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Jul 4, 2024

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Uh oh!

hebasto commented Jul 4, 2024

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

fanquake commented Jul 4, 2024

Uh oh!

Uh oh!

TheCharlatan commented Jul 5, 2024

Uh oh!

hebasto commented Jul 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Jul 12, 2024

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theuni commented Jul 4, 2024 •

edited

Loading

DrahtBot commented Jul 4, 2024 •

edited

Loading

hebasto commented Jul 4, 2024 •

edited

Loading