Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-aux/m4/ax_boost_base.m4
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# Test for the Boost C++ headers of a particular version (or newer)
#
# If no path to the installed boost library is given the macro searchs
# If no path to the installed boost library is given the macro searches
# under /usr, /usr/local, /opt, /opt/local and /opt/homebrew and evaluates
# the $BOOST_ROOT environment variable. Further documentation is available
# at <http://randspringer.de/boost/index.html>.
Expand Down
2 changes: 1 addition & 1 deletion contrib/signet/getcoins.py
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def bitcoin_cli(rpc_command_and_params):
elif res.status_code == 404:
print('The specified faucet URL does not exist. Please check for any server issues/typo.')
elif res.status_code == 429:
print('The script does not allow for repeated transactions as the global faucet is rate-limitied to 1 request/IP/day. You can access the faucet website to get more coins manually')
print('The script does not allow for repeated transactions as the global faucet is rate-limited to 1 request/IP/day. You can access the faucet website to get more coins manually')
else:
print(f'Returned Error Code {res.status_code}\n{res.text}\n')
print('Please check the provided arguments for their validity and/or any possible typo.')
10 changes: 5 additions & 5 deletions contrib/tracing/p2p_monitor.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def loop(screen, bpf, peers):
info_panel = panel.new_panel(win)
info_panel.hide()

ROWS_AVALIABLE_FOR_LIST = curses.LINES - 5
ROWS_AVAILABLE_FOR_LIST = curses.LINES - 5
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rg "ROWS_AVALIABLE_FOR_LIST" shows empty, so all relevant references have been renamed.

scroll = 0

while True:
Expand All @@ -182,7 +182,7 @@ def loop(screen, bpf, peers):
if (ch == curses.KEY_DOWN or ch == ord("j")) and cur_list_pos < len(
peers.keys()) -1 and info_panel.hidden():
cur_list_pos += 1
if cur_list_pos >= ROWS_AVALIABLE_FOR_LIST:
if cur_list_pos >= ROWS_AVAILABLE_FOR_LIST:
scroll += 1
if (ch == curses.KEY_UP or ch == ord("k")) and cur_list_pos > 0 and info_panel.hidden():
cur_list_pos -= 1
Expand All @@ -194,14 +194,14 @@ def loop(screen, bpf, peers):
else:
info_panel.hide()
screen.erase()
render(screen, peers, cur_list_pos, scroll, ROWS_AVALIABLE_FOR_LIST, info_panel)
render(screen, peers, cur_list_pos, scroll, ROWS_AVAILABLE_FOR_LIST, info_panel)
curses.panel.update_panels()
screen.refresh()
except KeyboardInterrupt:
exit()


def render(screen, peers, cur_list_pos, scroll, ROWS_AVALIABLE_FOR_LIST, info_panel):
def render(screen, peers, cur_list_pos, scroll, ROWS_AVAILABLE_FOR_LIST, info_panel):
""" renders the list of peers and details panel

This code is unrelated to USDT, BCC and BPF.
Expand All @@ -214,7 +214,7 @@ def render(screen, peers, cur_list_pos, scroll, ROWS_AVALIABLE_FOR_LIST, info_pa
1, 0, (" Navigate with UP/DOWN or J/K and select a peer with ENTER or SPACE to see individual P2P messages"), curses.A_NORMAL)
screen.addstr(3, 0,
header_format % ("PEER", "OUTBOUND", "INBOUND", "TYPE", "ADDR"), curses.A_BOLD | curses.A_UNDERLINE)
peer_list = sorted(peers.keys())[scroll:ROWS_AVALIABLE_FOR_LIST+scroll]
peer_list = sorted(peers.keys())[scroll:ROWS_AVAILABLE_FOR_LIST+scroll]
for i, peer_id in enumerate(peer_list):
peer = peers[peer_id]
screen.addstr(i + 4, 0,
Expand Down
2 changes: 1 addition & 1 deletion depends/patches/native_libtapi/disable_zlib.patch
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
build: disable zlib

This isn't needed, and causes issues when clang-tblgen
is built, but trys to reach for a system libz.so.
is built, but tries to reach for a system libz.so.

diff --git a/build.sh b/build.sh
index e25d2f732..ec8422621 100755
Expand Down
2 changes: 1 addition & 1 deletion depends/patches/qt/no-xlib.patch
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ They are not necessary to compile QT.
cursor = createNonStandardCursor(cshape);

+#if QT_CONFIG(xcb_xlib) && QT_CONFIG(library)
// Create a glpyh cursor if everything else failed
// Create a glyph cursor if everything else failed
if (!cursor && cursorId) {
cursor = xcb_generate_id(conn);
@@ -597,6 +604,7 @@ xcb_cursor_t QXcbCursor::createFontCursor(int cshape)
Expand Down
2 changes: 1 addition & 1 deletion doc/Doxyfile.in
Original file line number Diff line number Diff line change
Expand Up @@ -1485,7 +1485,7 @@ EXT_LINKS_IN_WINDOW = NO

FORMULA_FONTSIZE = 10

# Use the FORMULA_TRANPARENT tag to determine whether or not the images
# Use the FORMULA_TRANSPARENT tag to determine whether or not the images
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config is named FORMULA_TRANSPARENT so this is purely a typo correction, no logic effect.

# generated for formulas are transparent PNGs. Transparent PNGs are not
# supported properly for IE 6.0, but are supported on all modern browsers.
#
Expand Down
6 changes: 3 additions & 3 deletions doc/release-notes/release-notes-0.10.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ Block and transaction handling:
- `bc42503` Use unordered_map for CCoinsViewCache with salted hash (optimization)
- `d4d3fbd` Do not flush the cache after every block outside of IBD (optimization)
- `ad08d0b` Bugfix: make CCoinsViewMemPool support pruned entries in underlying cache
- `5734d4d` Only remove actualy failed blocks from setBlockIndexValid
- `5734d4d` Only remove actually failed blocks from setBlockIndexValid
- `d70bc52` Rework block processing benchmark code
- `714a3e6` Only keep setBlockIndexValid entries that are possible improvements
- `ea100c7` Reduce maximum coinscache size during verification (reduce memory usage)
Expand Down Expand Up @@ -461,10 +461,10 @@ P2P protocol and network code:
- `20a5f61` Don't relay alerts to peers before version negotiation
- `b4ee0bd` Introduce preferred download peers
- `845c86d` Do not use third party services for IP detection
- `12a49ca` Limit the number of new addressses to accumulate
- `12a49ca` Limit the number of new addresses to accumulate
- `35e408f` Regard connection failures as attempt for addrman
- `a3a7317` Introduce 10 minute block download timeout
- `3022e7d` Require sufficent priority for relay of free transactions
- `3022e7d` Require sufficient priority for relay of free transactions
- `58fda4d` Update seed IPs, based on bitcoin.sipa.be crawler data
- `18021d0` Remove bitnodes.io from dnsseeds.

Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.10.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Wallet:
- N/A

GUI:
- `2c08406` some mac specifiy cleanup (memory handling, unnecessary code)
- `2c08406` some mac specify cleanup (memory handling, unnecessary code)
- `81145a6` fix OSX dock icon window reopening
- `786cf72` fix a issue where "command line options"-action overwrite "Preference"-action (on OSX)

Expand Down
6 changes: 3 additions & 3 deletions doc/release-notes/release-notes-0.12.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ Memory pool limiting
Previous versions of Bitcoin Core had their mempool limited by checking
a transaction's fees against the node's minimum relay fee. There was no
upper bound on the size of the mempool and attackers could send a large
number of transactions paying just slighly more than the default minimum
number of transactions paying just slightly more than the default minimum
relay fee to crash nodes with relatively low RAM. A temporary workaround
for previous versions of Bitcoin Core was to raise the default minimum
relay fee.
Expand Down Expand Up @@ -484,7 +484,7 @@ git merge commit are mentioned.
- #6307 `7ecdcd9` rpcban fixes (Jonas Schnelli)
- #6290 `5753988` rpc: make `gettxoutsettinfo` run lock-free (Wladimir J. van der Laan)
- #6262 `247b914` Return all available information via RPC call "validateaddress" (dexX7)
- #6339 `c3f0490` UniValue: don't escape solidus, keep espacing of reverse solidus (Jonas Schnelli)
- #6339 `c3f0490` UniValue: don't escape solidus, keep escaping of reverse solidus (Jonas Schnelli)
- #6353 `6bcb0a2` Show softfork status in getblockchaininfo (Wladimir J. van der Laan)
- #6247 `726e286` Add getblockheader RPC call (Peter Todd)
- #6362 `d6db115` Fix null id in RPC response during startup (Forrest Voight)
Expand Down Expand Up @@ -782,7 +782,7 @@ git merge commit are mentioned.
- #6103 `13b8282` Add ZeroMQ notifications (João Barbosa)
- #6692 `d5d1d2e` devtools: don't push if signing fails in github-merge (Wladimir J. van der Laan)
- #6728 `2b0567b` timedata: Prevent warning overkill (Wladimir J. van der Laan)
- #6713 `f6ce59c` SanitizeString: Allow hypen char (MarcoFalke)
- #6713 `f6ce59c` SanitizeString: Allow hyphen char (MarcoFalke)
- #5987 `4899a04` Bugfix: Fix testnet-in-a-box use case (Luke-Jr)
- #6733 `b7d78fd` Simple benchmarking framework (Gavin Andresen)
- #6854 `a092970` devtools: Add security-check.py (Wladimir J. van der Laan)
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.13.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ libraries such as Qt are no longer being tested on XP.

We do not have time nor resources to provide support for an OS that is
end-of-life. From 0.13.0 on, Windows XP is no longer supported. Users are
suggested to upgrade to a newer verion of Windows, or install an alternative OS
suggested to upgrade to a newer version of Windows, or install an alternative OS
that is supported.

No attempt is made to prevent installing or running the software on Windows XP,
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.13.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ git merge commit are mentioned.
- #8594 `ab295bb` Do not add random inbound peers to addrman (gmaxwell)
- #8940 `5b4192b` Add x9 service bit support to dnsseed.bluematt.me, seed.bitcoinstats.com (TheBlueMatt, cdecker)
- #8944 `685e4c7` Remove bogus assert on number of oubound connections. (TheBlueMatt)
- #8949 `0dbc48a` Be more agressive in getting connections to peers with relevant services (gmaxwell)
- #8949 `0dbc48a` Be more aggressive in getting connections to peers with relevant services (gmaxwell)

### Build system
- #8293 `fa5b249` Allow building libbitcoinconsensus without any univalue (luke-jr)
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.15.0.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ GUI startup crash issue

After upgrade to 0.15.0, some clients would crash at startup because a custom
fee setting was configured that no longer exists in the GUI. This is a minimal
patch to avoid this issue from occuring.
patch to avoid this issue from occurring.

0.15.0.1 Change log
====================
Expand Down
4 changes: 2 additions & 2 deletions doc/release-notes/release-notes-0.15.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ Low-level RPC changes

### Block and transaction handling
- #9801 `a8c5751` Removed redundant parameter from mempool.PrioritiseTransaction (gubatron)
- #9819 `1efc99c` Remove harmless read of unusued priority estimates (morcos)
- #9819 `1efc99c` Remove harmless read of unused priority estimates (morcos)
- #9822 `b7547fa` Remove block file location upgrade code (benma)
- #9602 `30ff3a2` Remove coin age priority and free transactions - implementation (morcos)
- #9548 `47510ad` Remove min reasonable fee (morcos)
Expand Down Expand Up @@ -527,7 +527,7 @@ Low-level RPC changes
- #10455 `0747d33` Simplify feebumper minimum fee code slightly (ryanofsky)
- #10522 `2805d60` [wallet] Remove unused variables (practicalswift)
- #8694 `177433a` Basic multiwallet support (luke-jr)
- #10598 `7a74f88` Supress struct/class mismatch warnings introduced in #10284 (paveljanik)
- #10598 `7a74f88` Suppress struct/class mismatch warnings introduced in #10284 (paveljanik)
- #9343 `209eef6` Don't create change at dust limit (morcos)
- #10744 `ed88e31` Use method name via __func__ macro (darksh1ne)
- #10712 `e8b9523` Add change output if necessary to reduce excess fee (morcos)
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.15.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ Low-level RPC changes
- #11252 `0fe2a9a` When clearing addrman clear mapInfo and mapAddr (instagibbs)
- #11527 `a2bd86a` Remove my testnet DNS seed (schildbach)
- #10756 `0a5477c` net processing: swap out signals for an interface class (theuni)
- #11531 `55b7abf` Check that new headers are not a descendant of an invalid block (more effeciently) (TheBlueMatt)
- #11531 `55b7abf` Check that new headers are not a descendant of an invalid block (more efficiently) (TheBlueMatt)
- #11560 `49bf090` Connect to a new outbound peer if our tip is stale (sdaftuar)
- #11568 `fc966bb` Disconnect outbound peers on invalid chains (sdaftuar)
- #11578 `ec8dedf` Add missing lock in ProcessHeadersMessage(...) (practicalswift)
Expand Down
6 changes: 3 additions & 3 deletions doc/release-notes/release-notes-0.18.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ Changes for particular platforms
- #15122 Expand help text for `importmulti` changes (jnewbery)
- #15186 remove duplicate solvable field from `getaddressinfo` (fanquake)
- #15209 zmq: log outbound message high water mark when reusing socket (fanquake)
- #15177 rest: Improve tests and documention of /headers and /block (promag)
- #15177 rest: Improve tests and documentation of /headers and /block (promag)
- #14353 rest: Add blockhash call, fetch blockhash by height (jonasschnelli)
- #15248 Compile on GCC4.8 (MarcoFalke)
- #14987 RPCHelpMan: Pass through Result and Examples (MarcoFalke)
Expand Down Expand Up @@ -924,7 +924,7 @@ Changes for particular platforms
- #14958 Remove race between connecting and shutdown on separate connections (promag)
- #15166 Pin shellcheck version (practicalswift)
- #15196 Update all `subprocess.check_output` functions to be Python 3.4 compatible (gkrizek)
- #15043 Build fuzz targets into seperate executables (MarcoFalke)
- #15043 Build fuzz targets into separate executables (MarcoFalke)
- #15276 travis: Compile once on trusty (MarcoFalke)
- #15246 Add tests for invalid message headers (MarcoFalke)
- #15301 When testing with --usecli, unify RPC arg to cli arg conversion and handle dicts and lists (achow101)
Expand Down Expand Up @@ -998,7 +998,7 @@ Changes for particular platforms
- #14433 Add checksum in gitian build scripts for ossl (TheCharlatan)
- #15165 contrib: Allow use of github api authentication in github-merge (laanwj)
- #14409 utils and libraries: Make 'blocksdir' always net specific (hebasto)
- #14839 threads: Fix unitialized members in `sched_param` (fanquake)
- #14839 threads: Fix uninitialized members in `sched_param` (fanquake)
- #14955 Switch all RNG code to the built-in PRNG (sipa)
- #15258 Scripts and tools: Fix `devtools/copyright_header.py` to always honor exclusions (Empact)
- #12255 Update bitcoin.service to conform to init.md (dongcarl)
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.19.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ distribution provides binaries for the RISC-V platform.
- #17427 Fix missing qRegisterMetaType for `size_t` (hebasto)
- #17695 disable File-\>CreateWallet during startup (fanquake)
- #17634 Fix comparison function signature (hebasto)
- #18062 Fix unintialized WalletView::progressDialog (promag)
- #18062 Fix uninitialized WalletView::progressDialog (promag)

### Tests and QA
- #17416 Appveyor improvement - text file for vcpkg package list (sipsorcery)
Expand Down
6 changes: 3 additions & 3 deletions doc/release-notes/release-notes-0.20.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ Build system
- #17998 Shortcut to close ModalOverlay (emilengler)
- #18007 Bugfix: GUI: Hide the HD/encrypt icons earlier so they get re-shown if another wallet is open (luke-jr)
- #18060 Drop PeerTableModel dependency to ClientModel (promag)
- #18062 Fix unintialized WalletView::progressDialog (promag)
- #18062 Fix uninitialized WalletView::progressDialog (promag)
- #18091 Pass clientmodel changes from walletframe to walletviews (jonasschnelli)
- #18101 Fix deprecated QCharRef usage (hebasto)
- #18121 Throttle GUI update pace when -reindex (hebasto)
Expand Down Expand Up @@ -698,7 +698,7 @@ Build system
- #18224 Make AnalyzePSBT next role calculation simple, correct (instagibbs)
- #18228 Add missing syncwithvalidationinterfacequeue (MarcoFalke)
- #18247 Wait for both veracks in `add_p2p_connection` (MarcoFalke)
- #18249 Bump timeouts to accomodate really slow disks (MarcoFalke)
- #18249 Bump timeouts to accommodate really slow disks (MarcoFalke)
- #18255 Add `bad-txns-*-toolarge` test cases to `invalid_txs` (MarcoFalke)
- #18263 rpc: change setmocktime check to use IsMockableChain (gzhao408)
- #18285 Check that `wait_until` returns if time point is in the past (MarcoFalke)
Expand Down Expand Up @@ -757,7 +757,7 @@ Build system
- #17134 Add switch on enum example to developer notes (hebasto)
- #17142 Update macdeploy README to include all files produced by `make deploy` (za-kk)
- #17146 github: Add warning for bug reports (laanwj)
- #17157 Added instructions for how to add an upsteam to forked repo (dannmat)
- #17157 Added instructions for how to add an upstream to forked repo (dannmat)
- #17159 Add a note about backporting (carnhofdaki)
- #17169 Correct function name in ReportHardwareRand() (fanquake)
- #17177 Describe log files + consistent paths in test READMEs (fjahr)
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.4.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ http://gitorious.org/bitcoin/bitcoind-stable/archive-tarball/v0.4.3#.tar.gz

BUG FIXES

Cease locking memory used by non-sensitive information (this caused a huge performance hit on some platforms, especially noticable during initial blockchain download).
Cease locking memory used by non-sensitive information (this caused a huge performance hit on some platforms, especially noticeable during initial blockchain download).
Fixed some address-handling deadlocks (client freezes).
No longer accept inbound connections over the internet when Bitcoin is being used with Tor (identity leak).
Use the correct base transaction fee of 0.0005 BTC for accepting transactions into mined blocks (since 0.4.0, it was incorrectly accepting 0.0001 BTC which was only meant to be relayed).
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.5.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ http://sourceforge.net/projects/bitcoin/files/Bitcoin/bitcoin-0.5.1/
This is a bugfix-only release.

This release includes 13 translations, including 5 new translations:
Italian, Hungarian, Ukranian, Portuguese (Brazilian) and Simplified Chinese.
Italian, Hungarian, Ukrainian, Portuguese (Brazilian) and Simplified Chinese.
More translations are welcome; join the project at Transifex if you can help:
https://www.transifex.net/projects/p/bitcoin/

Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.5.2.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ http://gitorious.org/bitcoin/bitcoind-stable/archive-tarball/v0.5.2#.tar.gz
BUG FIXES

Check all transactions in blocks after the last checkpoint (0.5.0 and 0.5.1 skipped checking ECDSA signatures during initial blockchain download).
Cease locking memory used by non-sensitive information (this caused a huge performance hit on some platforms, especially noticable during initial blockchain download; this was
Cease locking memory used by non-sensitive information (this caused a huge performance hit on some platforms, especially noticeable during initial blockchain download; this was
not a security vulnerability).
Fixed some address-handling deadlocks (client freezes).
No longer accept inbound connections over the internet when Bitcoin is being used with Tor (identity leak).
Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.7.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ JSON-RPC API
* Added 'listaddressgroupings' for better coin control
* Rework getblock call.
* Remove deprecated RPC 'getblocknumber'
* Remove superceded RPC 'getmemorypool' (see BIP 22, above)
* Remove superseded RPC 'getmemorypool' (see BIP 22, above)
* listtransactions output now displays "smart" times for transactions,
and 'blocktime' and 'timereceived' fields were added

Expand Down
2 changes: 1 addition & 1 deletion doc/release-notes/release-notes-0.9.4.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ Command-line options:
- `cd5164a` Make -proxy set all network types, avoiding a connect leak.

P2P:
- `bb424e4` Limit the number of new addressses to accumulate
- `bb424e4` Limit the number of new addresses to accumulate

RPC:
- `0a94661` Disable SSLv3 (in favor of TLS) for the RPC client and server.
Expand Down
Loading