Skip to content

Conversation

fanquake
Copy link
Member

Github-Pull: #30149
Rebased-From: 9f4ff1e

@DrahtBot
Copy link
Contributor

DrahtBot commented May 28, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK theuni, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed. Make sure to run all tests locally, according to the
documentation.

Possibly this is due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.

Leave a comment here, if you need help tracking down a confusing failure.

Debug: https://github.com/bitcoin/bitcoin/runs/25508980268

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a4eff2

git diff origin/pr/30184..9f4ff1e9659597307f62510f1885ad8da3a1d9a3 -- contrib/windeploy/win-codesign.cert
(empty)

Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7a4eff2

@fanquake fanquake merged commit fb9890c into bitcoin:25.x May 29, 2024
@fanquake fanquake deleted the 25_x_backport_win_cert branch May 29, 2024 08:09
@bitcoin bitcoin locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants