build: remove use of TARGET_OS and BUILD_OS #23969
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
3120c29 to
895e3b6
Compare
|
Fixed the issue with the android build. |
895e3b6 to
b6b6094
Compare
|
Simplified this further and removed |
b6b6094 to
3f84c22
Compare
This was referenced Jan 6, 2022
hebasto
reviewed
Jan 8, 2022
There was a problem hiding this comment.
Approach ACK 3f84c22
Why not being consistent about preferring AS_CASE over shell's case, at least within this PR?
See:
- https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Balancing-Parentheses
- https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#case
- https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Common-Shell-Constructs
3f84c22 to
a9f3b56
Compare
This was referenced Feb 20, 2022
a9f3b56 to
8c5c090
Compare
8c5c090 to
d79311e
Compare
d79311e to
3e45498
Compare
|
Rebased past #24681. |
Guix builds
|
In favour of checking $host_os and $build_os directly.
3e45498 to
86851c8
Compare
|
Concept ACK GUIX hashes on x86, mine match fanquake's latest round |
laanwj
reviewed
Apr 14, 2022
| if test "$TARGET_OS" = "windows"; then | ||
| NATPMP_CPPFLAGS="-DSTATICLIB -DNATPMP_STATICLIB" | ||
| fi | ||
| AS_CASE([$host_os], [*mingw*], [NATPMP_CPPFLAGS="-DSTATICLIB -DNATPMP_STATICLIB"]) |
There was a problem hiding this comment.
What about non-mingw windows? Does this make it more difficult to switch compilers later? E.g. does the clang windows tuple have mingw in it?
There was a problem hiding this comment.
I think in that case there is a different tuple. Doing this isn't really a priority, so I'll close this for now, and we can potentially revisit later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favour of checking
$host_osand$build_osdirectly.Guix Build (on x86_64):