Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 13, 2021

Assume should only be used when a failed check is recoverable. The checks here don't recover and would run into UB, so use Assert instead.

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-review ACK fa26c55

Copy link
Member

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fanquake fanquake merged commit ab879d9 into bitcoin:master Dec 14, 2021
@maflcko maflcko deleted the 2112-refAssertCoinWallet branch December 14, 2021 08:26
@bitcoin bitcoin locked and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants