Skip to content

fuzz: Add regression test for wallet crash #23444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fuzz: Add regression test for wallet crash #23444

wants to merge 2 commits into from

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Nov 5, 2021

This adds a regression fuzz test for the bug fixed in commit 24abd83.

Steps to test:

git show 0fbaef9676a1dcb84bcf95afd8d994831ab327b6 ./src/policy/feerate.cpp | git apply --reverse
# compile fuzz test ...
FUZZ=wallet_notifications ./src/test/fuzz/fuzz
# wait and observe crash ...

@maflcko
Copy link
Member Author

maflcko commented Nov 5, 2021

Example crash: crash-6cd0f86f18ce0ec5b48beb59c602c8f807fe197a.bin.txt

@maflcko
Copy link
Member Author

maflcko commented Nov 5, 2021

Be aware that the crash is currently non-deterministic. I presume because the wallet's keys are non-deterministic (random). It might be a good idea to make the wallet generation deterministic for this fuzz test.

@DrahtBot DrahtBot added the Wallet label Nov 5, 2021
@maflcko
Copy link
Member Author

maflcko commented Nov 10, 2021

It might be a good idea to make the wallet generation deterministic for this fuzz test.

Done

@jamesob
Copy link
Contributor

jamesob commented Nov 10, 2021

Concept ACK - will review soon

@maflcko
Copy link
Member Author

maflcko commented Nov 10, 2021

Ok, it is still not deterministic 😞 . Maybe the coin selection is too random?

@DrahtBot DrahtBot mentioned this pull request Dec 19, 2021
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 19, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25218 (refactor: introduce generic 'Result' class and connect it to CreateTransaction and GetNewDestination by furszy)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@achow101
Copy link
Member

Ok, it is still not deterministic disappointed . Maybe the coin selection is too random?

It's probably the random selection algorithm.

@DrahtBot DrahtBot mentioned this pull request Mar 2, 2022
Closed
@fanquake
Copy link
Member

Ok, it is still not deterministic 😞 . Maybe the coin selection is too random?

Has this situation improved at all with recent coin selection changes?

@DrahtBot DrahtBot mentioned this pull request May 26, 2022
Merged
@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@achow101
Copy link
Member

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

@achow101 achow101 closed this Oct 12, 2022
@maflcko maflcko mentioned this pull request Mar 17, 2023
Closed
@bitcoin bitcoin locked and limited conversation to collaborators Oct 12, 2023
@maflcko maflcko deleted the 2111-fuzzWall branch November 16, 2023 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs rebase Tests Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maflcko @jamesob @DrahtBot @achow101 @fanquake