Skip to content

test: Extend stale_tip_peer_management test #23352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: Extend stale_tip_peer_management test #23352

wants to merge 1 commit into from

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Oct 25, 2021

Add coverage for the case where a peer is protected when it pretends to have a block.

Also, add some ASSERT_DEBUG_LOG to document the tests for the reader.

@DrahtBot DrahtBot mentioned this pull request Oct 25, 2021
Closed
@DrahtBot DrahtBot added the Tests label Oct 25, 2021
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 25, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept ACK jamesob, jonatack, mzumsande

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #28464 (net: improve max-connection limits code by mzumsande)
  • #28463 (p2p: Increase inbound capacity for block-relay only connections by mzumsande)
  • #28155 (net: improves addnode / m_added_nodes logic by sr-gi)
  • #26812 (test: add end-to-end tests for CConnman and PeerManager by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced Oct 25, 2021
Closed
Merged
This was referenced Nov 29, 2021
Merged
Merged
@jamesob
Copy link
Contributor

jamesob commented Dec 6, 2021

Concept ACK, will review soon

This was referenced Mar 21, 2022
Merged
Merged
Closed
Merged
@DrahtBot DrahtBot mentioned this pull request Apr 5, 2022
Merged
@jonatack
Copy link
Member

Concept ACK

@DrahtBot DrahtBot mentioned this pull request Apr 25, 2022
Merged
This was referenced Jul 25, 2022
Merged
Closed
@DrahtBot DrahtBot mentioned this pull request Aug 4, 2022
Merged
@DrahtBot DrahtBot mentioned this pull request Aug 13, 2022
Closed
@DrahtBot DrahtBot mentioned this pull request Nov 30, 2022
Closed
@DrahtBot DrahtBot mentioned this pull request Dec 14, 2022
Merged
@LarryRuane LarryRuane mentioned this pull request Feb 6, 2023
Open
@DrahtBot DrahtBot mentioned this pull request Mar 6, 2023
Merged
@DrahtBot DrahtBot mentioned this pull request Apr 1, 2023
Closed
@achow101 achow101 requested a review from jamesob April 25, 2023 15:30
@theuni
Copy link
Member

theuni commented Apr 25, 2023

Ping @MarcoFalke, apparently :)

@jonatack
Copy link
Member

I wonder if it's possible (and worth it) to tweak the test such that it would have caught #26172.

I have a test for that but haven't made the PR yet (I'll do that this week). I'll compare what I have to this PR since there's likely some overlap.

@LarryRuane any update on the test?

@maflcko maflcko force-pushed the 2110-testDos branch 2 times, most recently from fab26f2 to abd2dad Compare September 20, 2023 16:42
@DrahtBot DrahtBot changed the title test: Extend stale_tip_peer_management test test: Extend stale_tip_peer_management test Sep 20, 2023
This was referenced Sep 20, 2023
Merged
Open
@DrahtBot DrahtBot mentioned this pull request Oct 6, 2023
Open
@DrahtBot DrahtBot mentioned this pull request Oct 20, 2023
Open
This was referenced Oct 29, 2023
Closed
Merged
@maflcko maflcko closed this Feb 6, 2024
@maflcko maflcko deleted the 2110-testDos branch February 6, 2024 10:46
@adamjonas adamjonas mentioned this pull request Mar 14, 2024
Open
@bitcoin bitcoin locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesob jamesob Awaiting requested review from jamesob

1 more reviewer

@mzumsande mzumsande mzumsande left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CI failed Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maflcko @DrahtBot @jamesob @jonatack @achow101 @LarryRuane @theuni @mzumsande