Skip to content

Use stricter ToIntegral over LocaleIndependentAtoi where possible #23184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use stricter ToIntegral over LocaleIndependentAtoi where possible #23184

wants to merge 3 commits into from

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Oct 5, 2021

No need to use LocaleIndependentAtoi when a string is entirely composed of IsDigits and ToIntegral is sufficient.

@maflcko maflcko mentioned this pull request Oct 5, 2021
Merged
@practicalswift
Copy link
Contributor

Concept ACK

@maflcko
Copy link
Member Author

maflcko commented Oct 5, 2021

nvm.

This is not a refactor.

@maflcko maflcko closed this Oct 5, 2021
@maflcko maflcko deleted the 2110-ToIntegral branch October 5, 2021 11:21
@bitcoin bitcoin locked and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maflcko @practicalswift