ci: Enable feature_asmap.py test on native Windows #23103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed when, with what change? Probably easier to just mention this in #23102. |
In #23084.
Agree. @MarcoFalke ? |
b9ea277 to
b14415d
Compare
maflcko
reviewed
Sep 27, 2021
.cirrus.yml
Outdated
| @@ -152,7 +151,7 @@ task: | |||
| - netsh int ipv4 set dynamicport tcp start=1025 num=64511 | |||
| - netsh int ipv6 set dynamicport tcp start=1025 num=64511 | |||
| # TODO enable '--extended' and drop '--exclude'. | |||
There was a problem hiding this comment.
Also, wondering if --extended pass by now
There was a problem hiding this comment.
Also, wondering if
--extendedpass by now
b14415d to
4befc8f
Compare
|
Updated comment. |
|
cr ACK 4befc8f |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #23084. It enables the
feature_asmap.pyfunctional test which is fixed in #23084.