system: skip trying to set the locale on NetBSD #22390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just treat it the same as the other BSDs. Fixes bitcoin#17379.
|
Concept ACK |
|
Concept ACK This change matches the intention of the comment above the changed line. |
|
I wonder at some point it wont make more sense to make this override Linux specific, "instead of all UNIXy systems-except-BSDs and MacOS". Anyhow, |
|
cr ACK fdd7144 |
Going to merge this for now. Agree that we could rework how this is done in future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just treat it the same as the other BSDs.
Fixes #17379.