Skip to content

build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat #22281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

build: Avoid @GLIBC_2.29 libm symbols when --enable-glibc-back-compat #22281

wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Jun 19, 2021 •
edited
Loading

This PR is a partial fix for #21454 (see #22287 for the complete fix for the bitcoind compatibility).

Gitian builds:

Generating report
28c2e625cc23ab3c306565df6b49e8883518ad478d93fec13ef72c5e4904c476  bitcoin-9922cda0823a-aarch64-linux-gnu-debug.tar.gz
69aabc323eb1b6d243ab0b786f61056dcd5be5bb938b93ec3890de5c1aec9141  bitcoin-9922cda0823a-aarch64-linux-gnu.tar.gz
22df86a8e77f2f8472871067baa09b31ed932ada335584df42a4398743989c54  bitcoin-9922cda0823a-arm-linux-gnueabihf-debug.tar.gz
4ee9ae9c384efca953feca92149009909ff3ba653a0fb03b2712670526350018  bitcoin-9922cda0823a-arm-linux-gnueabihf.tar.gz
d377f8e6d4d9243ceafa1cf016837b3c1796d85926165333497d2b33155a1bac  bitcoin-9922cda0823a-powerpc64-linux-gnu-debug.tar.gz
68af39d9bcfabc6c00de82d222930dfc070d7051836e469505811256eb03ca3e  bitcoin-9922cda0823a-powerpc64-linux-gnu.tar.gz
0ebe6f51b21e4fc6f6329c823da7937385832a44b950208a3406be00866586cd  bitcoin-9922cda0823a-powerpc64le-linux-gnu-debug.tar.gz
5754d69beb6359c9bb1a01c98c71bfa1f49460759646375c02de6f05af3258b4  bitcoin-9922cda0823a-powerpc64le-linux-gnu.tar.gz
3f68d9da14da0db4a79528673fc8c4cd2f37c6fa51778d3027f2ba3d031f4c98  bitcoin-9922cda0823a-riscv64-linux-gnu-debug.tar.gz
0ef6587d65400498aeb167bc6a098ab58c38df00faa85e8d1fc1530fca30f300  bitcoin-9922cda0823a-riscv64-linux-gnu.tar.gz
8c0eaf703216eda1d4325921d741904a139150518ddd58143147513e527b24d9  bitcoin-9922cda0823a-x86_64-linux-gnu-debug.tar.gz
fad8a676153efe0106661211fe632c4e6a7d4c28e9db6b665f12e9db578238fb  bitcoin-9922cda0823a-x86_64-linux-gnu.tar.gz
c5c0368207e7f00dda5f13eca94f73d8b67fa930b5dd225deb9848f4c2872ab0  src/bitcoin-9922cda0823a.tar.gz
08171dcfe016b4b14bd242a9ded01557791fe27b57486352fabedb040c96a739  bitcoin-core-linux-22-res.yml
Done.

This was referenced Jun 20, 2021
Closed
Closed
Merged
@laanwj laanwj added this to the 22.0 milestone Jun 21, 2021
@laanwj
Copy link
Member

laanwj commented Jun 21, 2021

Code review ACK 9922cda

@DrahtBot
Copy link
Contributor

Guix builds

File commit 6a67366
(master)		 commit edc58d9
(master and this pull)
SKIPATTEST.TAG e3b0c44298fc1c14... e3b0c44298fc1c14...
*.tar.gz ed3096aa949f1b56... 437f2a9ec1a9d80b...
guix_build.log 7920a375a22476b1... 1f84690a7c60a606...
guix_build.log.diff b7c87f3cf4adebaf...

@hebasto hebasto mentioned this pull request Jun 22, 2021
Closed
@DrahtBot
Copy link
Contributor

Gitian builds

File commit 398dd67
(master)		 commit c49b6bd
(master and this pull)
*-osx-unsigned.dmg 92e2d116b58d4214... 3343b0ef68879b95...
*-osx64.tar.gz 02578406a266bd45... 2c05b10e2f78a251...
*.tar.gz b16fc2a40cba5b8c... 23a5ddc19a9eefde...
bitcoin-core-osx-22-res.yml f2972b31a41adb54... a2fa102cb93fc097...
linux-build.log 6c8e74cad31e39a3... a4daf3adae600c3b...
osx-build.log bb8f3e7c16328172... 280d6f967c42530e...
win-build.log 2eea226b75083143... 63ffc6aba4e9fdcd...
bitcoin-core-osx-22-res.yml.diff 9c30e0df68bc0d1c...
linux-build.log.diff aca0ae0b74dd185b...
osx-build.log.diff 8313890ba83f5b51...
win-build.log.diff 0587ddbb0d0b3bd3...

@hebasto
Copy link
Member Author

hebasto commented Jul 1, 2021

Closing in favor of #22365.

@hebasto hebasto closed this Jul 1, 2021
@hebasto hebasto mentioned this pull request Jul 8, 2021
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @laanwj @DrahtBot @fanquake @maflcko