Bitcoin-Qt: add "send coins" to context menu in addressbook #2215
Conversation
|
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/cf39a9f398e190199dd453947e2724ba860b9f98 for binaries and test log. This could happen for one of several reasons:
|
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/20b6c6089480e4d9ac9602dbfe5affd3f9625b23 for binaries and test log. |
|
@luke-jr It was one of your feature-requests, can you take a look if this does what you wanted ;)? |
| @@ -17,6 +17,13 @@ | |||
| #include "qrcodedialog.h" | |||
| #endif | |||
|
|
|||
| // Used to pass flags to the AddressBookPage::processCtxMenuClick() function | |||
| enum CtxMenuClickFlags { | |||
There was a problem hiding this comment.
No need to make this 'flags', it can be simply an enum as you're using 'case' to distinguish the cases
There was a problem hiding this comment.
Are you talking about just renaming it to to CtxMenuClick?
|
@laanwj Addressed your concerns :). |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/b621e2841b18822247bf18dab1b614182d55086a for binaries and test log. |
| void AddressBookPage::onSendCoins_clicked() | ||
| { | ||
| QTableView *table = ui->tableView; | ||
| QModelIndexList indexes = table->selectionModel()->selectedRows(AddressTableModel::Address); |
There was a problem hiding this comment.
I see what you meant with duplicate code now. The best way to get rid of this would have been to factor out the utility code (ie, make a getSelectedIndices).
Then again, the overhead is pretty minimal, so it's not really needed.
|
ACK |
|
@laanwj I'll rebase after the header / cpp cleanup got in, so perhaps we can also get this in soonTM. |
- allows to directly select an address from the addressbook, chose "send coins" from the context menu, which sends you to sendcoins tab and fills in the selected address
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/311993ab106c250a1779bfdb649cf4f8c2416fb5 for binaries and test log. |
|
Yes, this one should be merged asap |
Bitcoin-Qt: add "send coins" to context menu in addressbook
Bitcoin-Qt: add "send coins" to context menu in addressbook
coins" from the context menu, which sends you to sendcoins tab and fills
in the selected address
Fixes: #2176 and #861