wallet: remove GetScriptPubKeyMan spam #21880
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #21716
Problem:
In
AddWalletDescriptor
we iterate through every combination ofinternal/external
andOutputType
. For each combination we callGetScriptPubKeyMan
and when the combination is invalid we would log a warningscriptPubKey Manager for output type
and thus causing the spam in the logs.My approach
Since there is only one
ScriptPubKeyMan
that has the same id asold_spk_man_id
, we would instead iterate through both the map and erase theScriptPubKeyMan
once we find it.The code that causes the spam:
src/wallet/wallet.cpp