Send fewer feefilter messages (avoid the wobbling number issue) #21841
Conversation
e.g. with |
121b280 to
9c0fec5
Compare
|
I've changed the algorithm - simpler - it only sends a new feefilter if the current rounded filter (so still giving privacy) is closer to the current filter than the last sent one was. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Closing for now. The tests failed, this needs rebase and there hasn't been any activity for months. You can leave a comment if you want this to be reopened. (Or create a new pull, since there haven't been any comments here). Though, please make sure the code is passing tests and is ready for review. |
This is a simpler replacement for #21805. The only change now to the current functionality is that it requires that the actual (i.e. not rounded up or down) minrelayfee has changed since the last sent feefilter message.
This helps increase privacy (by not sending repeated messages above and below the actual, thereby revealing the actual), and reduces network traffic (due to fewer messages).
This pull will make almost no functional changes without #21618 given that it's extremely rare that the actual minrelayfee will remain constant, so it's safe to merge, and will be there for privacy safety in the event that a pull is later merged which encourages the minrelayfee to remain constant.
TODO - need to fix the test that is failing as soon as I work out how to run the test - can someone comment with this info please?