Remove fClient #2161
Merged
Remove fClient #2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/74102ce089021edd05214c2f0c19b96b11659fc3 for binaries and test log. |
|
ACK, but I think you should collapse the empty curly braces. |
Client (SPV) mode never got implemented entirely, and whatever part was already working, is likely not been tested (or even executed at all) for the past two years. This removes it entirely. If we want an SPV implementation, I think we should first get the block chain data structures to be encapsulated in a class implementing a standard interface, and then writing an alternate implementation with SPV semantics.
|
@gavinandresen done |
|
ACK |
|
I was thinking that we should archive satoshi code snippets somewhere, perhaps in contrib/ He did a bit of fClient work, emailed some code snippets to others, etc. Would be nice to collect the Not Used Yet ones, and not bury them in email boxes or git history. |
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c2b72ba27f0b41d15c70818cb974d4fe7188d17c for binaries and test log. |
|
@jgarzik : the fClient work is in the 'blockheaders' branch here. The only code snippet I got from Satoshi is now merged (the signature cache). |
laudney
pushed a commit
to reddcoin-project/reddcoin-3.10
that referenced
this pull request
Mar 19, 2014
Remove fClient
owlhooter
pushed a commit
to owlhooter/mazacoin-new
that referenced
this pull request
Oct 11, 2018
* Adjust diff for slow testnet/devnet blocks a bit smoother * bump to 000000000000000000000000000000000000000000000000003ff00000000000 * bump slow blocks to 10 minutes
guruvan
added a commit
to guruvan/maza
that referenced
this pull request
Nov 8, 2018
* MAZA-POS: (5575 commits) Mazafication of code More mazafication More mazafications and compile correction fixes fix for build issues fix for build issues fix string in net.cpp correct pow.cpp correct validation.cpp fixing for build errors fix typo Merge remote-tracking branch 'origin/MAZA-POS' into MAZA-POS merge to dash rebase Release notes 0.12.3.3 Remove redundant parameter fCheckDuplicateInputs from CheckTransaction Fix crash bug with duplicate inputs within a transaction Bump to 0.12.3.3 Release notes 0.12.3.2 (bitcoin#2174) Add tests for special rules for slow blocks on devnet/testnet (bitcoin#2176) Allow mining min diff for very slow (2h+) blocks (bitcoin#2175) Fix issues with selections on Masternode tab (bitcoin#2170) Sync mn list and mnw list from 3 peers max (bitcoin#2169) A few devnet related fixes (bitcoin#2168) Adjust diff for slow testnet/devnet blocks a bit smoother (bitcoin#2161) Make PS Buttons not react to spacebar (bitcoin#2154) Bump to 0.12.3.2 (bitcoin#2173) Bump to 0.12.3.1 (bitcoin#2158) Update release notes (bitcoin#2155) Use correct protocol when serializing messages in reply to `getdata` (bitcoin#2157) Fix p2pkh tests asserts (bitcoin#2153) Fix block value/payee validation in lite mode (bitcoin#2148) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client (SPV) mode never got implemented entirely, and whatever part was already working, is likely not been tested (or even executed at all) for the past two years. This removes it entirely.
If we want an SPV implementation, I think we should first get the block chain data structures to be encapsulated in a class implementing a standard interface, and then writing an alternate implementation with SPV semantics.