build, qt: Simplifies checks for -fPIE and -fPIC compatibility
#21570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitian builds:
|
Guix builds: |
jarolrod
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Contributing GUIX hashes, mine match @hebasto
find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
5362e85820b3ec4bfae9d5d1de9e79bd8f96ab373ebc96a097b21b6caf9efcf4 output/bitcoin-f88a7051190e-aarch64-linux-gnu-debug.tar.gz
659285ebfa690d584337c4ce45cf9056a2902bf78fb833d8ee12858170960412 output/bitcoin-f88a7051190e-aarch64-linux-gnu.tar.gz
3c2a404937d99c0890cad9097998397e8765e66f8efa0552b2374623ce645fc9 output/bitcoin-f88a7051190e-arm-linux-gnueabihf-debug.tar.gz
2ce15e053ca6c22f1683590ca262d4e8a0e99161293b9981ce4f7d8b4da97669 output/bitcoin-f88a7051190e-arm-linux-gnueabihf.tar.gz
5eb5379af5d01cbf5009b0c451e3c7f068c63d781c6f1d3260c378b56bade136 output/bitcoin-f88a7051190e-osx-unsigned.dmg
4bcd48bf7bd84137106c78995b730d254d012acec8e181b17104ae445b820f1e output/bitcoin-f88a7051190e-osx-unsigned.tar.gz
1f97d02cd897294f1ffb7d12efb227aced384c7ceb8c4be5c83f54745dd1796f output/bitcoin-f88a7051190e-osx64.tar.gz
a80932419d2d3d240297f164e02128e2e8e954a7eb0eebbaf05610935f105d7d output/bitcoin-f88a7051190e-powerpc64-linux-gnu-debug.tar.gz
f6b0d20189511c73e17a5c80626d2954680ed75123c9bfffb58040a4363e6323 output/bitcoin-f88a7051190e-powerpc64-linux-gnu.tar.gz
efdfc396a7fc408a2fcd61a8fff1b68c12b56faf67851712f0f04e90c20da5e6 output/bitcoin-f88a7051190e-powerpc64le-linux-gnu-debug.tar.gz
a1ddab4d7f3a8ec38764830799f6ab2cab0073d60ce836298aadb21c0c3d3a20 output/bitcoin-f88a7051190e-powerpc64le-linux-gnu.tar.gz
1f4ec1dea68cd39e2ae08705c9fda5607a4b49ee53b01f3ef9e9a093f177dad5 output/bitcoin-f88a7051190e-riscv64-linux-gnu-debug.tar.gz
96430dd3e8e70e52502983c3b584c80f7cd4f8e67937fb10ef7a3fc47f76e5ab output/bitcoin-f88a7051190e-riscv64-linux-gnu.tar.gz
22d908d26e5746a6348dadb04502470d53554697a78df12cc461b2a27f0b7b5f output/bitcoin-f88a7051190e-win-unsigned.tar.gz
b0f1659967d03ab7099429c4d9e5a4520b3796906c1b3b60e1509fc8b4f14472 output/bitcoin-f88a7051190e-win64-debug.zip
20398fd8d45a49c34591d08bc1c32166d2c0d8afee90cbbd8220296ca5c1f7c0 output/bitcoin-f88a7051190e-win64-setup-unsigned.exe
0eee05248ddd27f138ece1eb57497e82bb5fcaeb95970513a98fca9ad37b3360 output/bitcoin-f88a7051190e-win64.zip
02161a94c043dc7959b88d2b84448d5787017ce40ebb76a703005940b9212f3a output/bitcoin-f88a7051190e-x86_64-linux-gnu-debug.tar.gz
adfde597947b475e4c3aa6be6284c9c8f04d602537b8cb121582ae8d741b680b output/bitcoin-f88a7051190e-x86_64-linux-gnu.tar.gz
d119be26184a03a1aa50c531495d5dfe5a078f989738b049d20d44a4ed4301e6 output/src/bitcoin-f88a7051190e.tar.gz
I think you need to elaborate here. For example, the PR description (and commit message) could include:
Adding more information not only means that more contributors can, or will be more likely to review, but any security related change should be better summarized than "some changes happened in a dependency header". |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
|
What is the status of this PR? |
|
The PR description has been updated aiming to address @fanquake's #21570 (comment). |
QT_REDUCE_RELOCATIONS
Guix builds: |
QT_REDUCE_RELOCATIONSThe checks in global/qglobal.h header are correct since Qt 5.4.2.
|
Rebased a308515 -> bbd09b1 (pr21570.02 -> pr21570.03) due to the conflict with #24391. |
-fPIE and -fPIC compatibility
Guix builds on
|
This was referenced Apr 17, 2022
|
Guix hashes x86 |
So is there a reason for us to actually keep these checks in our configure at all then? |
To choose between |
Isn't the most relevant thing whether qt has been configured with |
Correct.
Agree. Mind suggesting one with a nice wording? |
|
Are you still working on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in bitcoin/bitcoin#6978:
To be precise, since Qt 5.4.2 the
qglobal.hheader implements the correct checks for-fPIEand-fPICcompatibility:As now we require GCC 8.1+ and Qt 5.11.3+, it is safe to rely on Qt's checks. The removed lines
are redundant now.
One of the easiest way to test this PR is
configure.logcomparison.No behavior change.