fuzz: Implement fuzzed_dns_lookup_function as a lambda #21443
Conversation
| const std::string name = fuzzed_data_provider.ConsumeRandomLengthString(512); | ||
| const unsigned int max_results = fuzzed_data_provider.ConsumeIntegral<unsigned int>(); | ||
| const bool allow_lookup = fuzzed_data_provider.ConsumeBool(); | ||
| const int default_port = fuzzed_data_provider.ConsumeIntegral<int>(); | ||
|
|
||
| auto fuzzed_dns_lookup_function = [&](const std::string&, bool) { |
There was a problem hiding this comment.
This is impossible to reuse if another FUZZ_TARGET() be added. It is ok since here we have just one FUZZ_TARGET() and if ever another one is added and reuse needed, then it could be done in another way.
There was a problem hiding this comment.
I think (and hope) that the netbase_dns_lookup fuzzing harness should cover all our low-level DNS fuzzing needs, so I think the probability that we'll need to call fuzzed_dns_lookup_function from another FUZZ_TARGET in the future is relatively low.
In other words: let's cross that fuzzing bridge when we come to it :)
There was a problem hiding this comment.
YAGNI (you ain't gonna need it)
|
cr ACK 7c8c140 |
|
3rd time today my ACK missed a merge by a few seconds...there are days like that :D |
Implement
fuzzed_dns_lookup_functionas a lambda.As wisely suggested by MarcoFalke in #19415 (comment). Thanks! :)