Skip to content

test: add test for corrupt wallet bdb logs #20974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

test: add test for corrupt wallet bdb logs #20974

wants to merge 3 commits into from

Conversation

ryanofsky
Copy link
Contributor

This PR adds a wallet test testing handling of corrupt BDB logs. It restores commit c6a2c26 from #18907 which was dropped because it triggered a memory leak, which is reported as #19034

@ryanofsky
Copy link
Contributor Author

Opened as draft PR to see if tests will pass now. If they do then #19034 can be closed and this can be reviewed and merged. Otherwise some more debugging will be required.

@fanquake fanquake added the Tests label Jan 21, 2021
@ryanofsky ryanofsky mentioned this pull request Jan 21, 2021
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 26, 2021 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Approach ACK jonasschnelli

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@DrahtBot DrahtBot mentioned this pull request Jan 26, 2021
Closed
@jonasschnelli
Copy link
Contributor

Approach ACK

@laanwj laanwj requested a review from achow101 January 27, 2021 18:47
@DrahtBot DrahtBot mentioned this pull request Sep 10, 2021
Merged
@DrahtBot DrahtBot mentioned this pull request Jan 21, 2023
Draft
@achow101
Copy link
Member

achow101 commented May 3, 2023 •
edited
Loading

I'm not sure that the issue this is trying to fix is really an issue worth spending time on since we have BDB slated for removal.

@achow101
Copy link
Member

Closing as this has been open as a draft for more than 2 years with basically no activity. The tests do not pass, nor does it appear that the issue has been fixed or will be fixed. The planned removal of BDB will also obsolete this test.

@achow101 achow101 closed this Sep 23, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achow101 achow101 Awaiting requested review from achow101

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanofsky @DrahtBot @jonasschnelli @achow101 @fanquake