Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2020

See #13378
I think a first step to improvement is to document precisely and correctly the current behavior, and then decide if that behavior is wanted and/or accepted.

@fanquake fanquake added the Docs label Dec 7, 2020
@ghost ghost changed the title [doc] Fix documenation of options onlynet and listenonion [doc] Fix documentation of options onlynet and listenonion Dec 7, 2020
See #13378
I think a first step to improvement is to document precisely and correctly the current behavior, and then decide if that behavior is wanted and/or accepted.
@ghost
Copy link
Author

ghost commented Dec 10, 2020

Added the dot, rebased&squashed.

Edit: There are two other lines in the output of bin/bitcoind --help that end with key=value. where the dot does not belong to the value, but marks the end of the sentence:

Equivalent to -chain=signet.
Equivalent to -chain=test. (even at the end of the paragraph, like it is in this PR the case, too)

(in src/chainparamsbase.cpp)

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 17, 2020

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ghost
Copy link
Author

ghost commented Dec 18, 2020

I would appreciate if this could be merged now, so it is done.

@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

@ghost
Copy link
Author

ghost commented Jan 31, 2021

The chaotic networking behavior is now reasonably documented with #20757 I guess, closing.

@ghost ghost closed this Jan 31, 2021
@ghost ghost deleted the patch-1 branch January 31, 2021 06:07
@jonatack
Copy link
Member

jonatack commented Feb 1, 2021

@wodry I'm sorry, I overlooked this pull when consolidating ideas for #20757, otherwise would have been happy to look at including it. Maybe it's complementary.

@ghost
Copy link
Author

ghost commented Feb 1, 2021

@jonatack Thanks, that's nice of you, nevermind, my impression is that the subject of Tor network and it's documentation is in good hands of you right now. There was some dynamic changes currently in this subject, I lost overview and only use release versions, so I do not know the current (master branch) behavior. I would check later time with new releases maybe again. Feel free to check if the issue I mentioned here is of any value anymore maybe worth to include :-)

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants